From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E301C43219 for ; Thu, 4 Nov 2021 17:34:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC22C61186 for ; Thu, 4 Nov 2021 17:34:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233879AbhKDRhS (ORCPT ); Thu, 4 Nov 2021 13:37:18 -0400 Received: from verein.lst.de ([213.95.11.211]:36174 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231667AbhKDRhP (ORCPT ); Thu, 4 Nov 2021 13:37:15 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 64F956732D; Thu, 4 Nov 2021 18:34:31 +0100 (CET) Date: Thu, 4 Nov 2021 18:34:31 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Chaitanya Kulkarni , Christoph Hellwig , "linux-block@vger.kernel.org" , "linux-raid@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-scsi@vger.kernel.org" , "target-devel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "dm-devel@redhat.com" , "axboe@kernel.dk" , "agk@redhat.com" , "snitzer@redhat.com" , "song@kernel.org" , "kbusch@kernel.org" , "sagi@grimberg.me" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "viro@zeniv.linux.org.uk" , "javier@javigon.com" , "johannes.thumshirn@wdc.com" , "bvanassche@acm.org" , "dongli.zhang@oracle.com" , "ming.lei@redhat.com" , "osandov@fb.com" , "willy@infradead.org" , "jefflexu@linux.alibaba.com" , "josef@toxicpanda.com" , "clm@fb.com" , "dsterba@suse.com" , "jack@suse.com" , "tytso@mit.edu" , "adilger.kernel@dilger.ca" , "jlayton@kernel.org" , "idryomov@gmail.com" , "danil.kipnis@cloud.ionos.com" , "ebiggers@google.com" , "jinpu.wang@cloud.ionos.com" Subject: Re: [RFC PATCH 0/8] block: add support for REQ_OP_VERIFY Message-ID: <20211104173431.GA31740@lst.de> References: <20211104064634.4481-1-chaitanyak@nvidia.com> <20211104071439.GA21927@lst.de> <661bcadd-a030-4a72-81ae-ef15080f0241@nvidia.com> <20211104173235.GI2237511@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211104173235.GI2237511@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Nov 04, 2021 at 10:32:35AM -0700, Darrick J. Wong wrote: > I also wonder if it would be useful (since we're already having a > discussion elsewhere about data integrity syscalls for pmem) to be able > to call this sort of thing against files? In which case we'd want > another preadv2 flag or something, and then plumb all that through the > vfs/iomap as needed? IFF we do this (can't answer if there is a need) we should not overload read with it. It is an operation that does not return data but just a status, so let's not get into that mess.