From: David Disseldorp <ddiss@suse.de>
To: linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org
Cc: Martin Wilck <mwilck@suse.com>,
viro@zeniv.linux.org.uk, willy@infradead.org,
David Disseldorp <ddiss@suse.de>
Subject: [PATCH v4 2/4] initramfs: print helpful cpio error on "crc" magic
Date: Wed, 10 Nov 2021 13:38:48 +0100 [thread overview]
Message-ID: <20211110123850.24956-3-ddiss@suse.de> (raw)
In-Reply-To: <20211110123850.24956-1-ddiss@suse.de>
Contrary to the buffer-format.rst documentation, initramfs cpio
extraction does not support "crc" archives, which carry "070702"
header magic. Make it a little clearer that "newc" (magic="070701") is
the only supported cpio format, by extending the POSIX.1 ASCII
(magic="070707") specific error message to also cover "crc" magic.
Signed-off-by: David Disseldorp <ddiss@suse.de>
---
init/initramfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/initramfs.c b/init/initramfs.c
index 2f79b3ec0b40..44e692ae4646 100644
--- a/init/initramfs.c
+++ b/init/initramfs.c
@@ -258,7 +258,7 @@ static int __init do_collect(void)
static int __init do_header(void)
{
if (memcmp(collected, "070701", 6)) {
- if (memcmp(collected, "070707", 6) == 0)
+ if (memcmp(collected, "0707", 4) == 0)
error("incorrect cpio method used: use -H newc option");
else
error("no cpio magic");
--
2.31.1
next prev parent reply other threads:[~2021-11-10 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 12:38 [PATCH v4 0/4] initramfs: "crc" cpio format and INITRAMFS_PRESERVE_MTIME David Disseldorp
2021-11-10 12:38 ` [PATCH v4 1/4] initramfs: refactor do_header() cpio magic checks David Disseldorp
2021-11-10 12:38 ` David Disseldorp [this message]
2021-11-10 17:30 ` [PATCH v4 2/4] initramfs: print helpful cpio error on "crc" magic Matthew Wilcox
2021-11-10 20:54 ` David Disseldorp
2021-11-10 12:38 ` [PATCH v4 3/4] docs: remove mention of "crc" cpio format support David Disseldorp
2021-11-10 12:38 ` [PATCH v4 4/4] initramfs: add INITRAMFS_PRESERVE_MTIME Kconfig option David Disseldorp
2021-11-10 12:42 ` [PATCH v4 0/4] initramfs: "crc" cpio format and INITRAMFS_PRESERVE_MTIME Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110123850.24956-3-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mwilck@suse.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).