From: Christoph Hellwig <hch@lst.de>
To: dan.j.williams@intel.com
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
nvdimm@lists.linux.dev, Dan Carpenter <dan.carpenter@oracle.com>
Subject: [PATCH] iomap: turn the byte variable in iomap_zero_iter into a ssize_t
Date: Wed, 8 Dec 2021 10:12:03 +0100 [thread overview]
Message-ID: <20211208091203.2927754-1-hch@lst.de> (raw)
bytes also hold the return value from iomap_write_end, which can contain
a negative error value. As bytes is always less than the page size even
the signed type can hold the entire possible range.
Fixes: c6f40468657d ("fsdax: decouple zeroing from the iomap buffered I/O code")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/iomap/buffered-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index b1511255b4df8..ac040d607f4fe 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -883,7 +883,7 @@ static loff_t iomap_zero_iter(struct iomap_iter *iter, bool *did_zero)
do {
unsigned offset = offset_in_page(pos);
- size_t bytes = min_t(u64, PAGE_SIZE - offset, length);
+ ssize_t bytes = min_t(u64, PAGE_SIZE - offset, length);
struct page *page;
int status;
--
2.30.2
next reply other threads:[~2021-12-08 9:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 9:12 Christoph Hellwig [this message]
2021-12-09 0:48 ` [PATCH] iomap: turn the byte variable in iomap_zero_iter into a ssize_t Darrick J. Wong
2021-12-09 0:55 ` Darrick J. Wong
2021-12-09 1:58 ` Dan Williams
2021-12-09 6:11 ` Christoph Hellwig
2021-12-09 18:19 ` Darrick J. Wong
2021-12-11 17:50 ` Matthew Wilcox
2021-12-13 7:38 ` Christoph Hellwig
2021-12-20 22:10 ` Matthew Wilcox
2021-12-21 4:12 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208091203.2927754-1-hch@lst.de \
--to=hch@lst.de \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).