From: Christian Brauner <brauner@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.com
Subject: Re: [PATCHSET 0/4] vfs: actually return fs errors from ->sync_fs
Date: Wed, 26 Jan 2022 09:21:53 +0100 [thread overview]
Message-ID: <20220126082153.mz5prdistkkvc6bc@wittgenstein> (raw)
In-Reply-To: <164316348940.2600168.17153575889519271710.stgit@magnolia>
On Tue, Jan 25, 2022 at 06:18:09PM -0800, Darrick J. Wong wrote:
> Hi all,
>
> While auditing the VFS code, I noticed that while ->sync_fs is allowed
> to return error codes to reflect some sort of internal filesystem error,
> none of the callers actually check the return value. Back when this
> callout was introduced for sync_filesystem in 2.5 this didn't matter
(Also, it looks like that most(/none?) of the filesystems that
implemented ->sync_fs around 2.5/2.6 (ext3, jfs, jffs2, reiserfs etc.)
actually did return an error?
In fact, 5.8 seems to be the first kernel to report other errors than
-EBADF since commit 735e4ae5ba28 ("vfs: track per-sb writeback errors
and report them to syncfs"?)
next prev parent reply other threads:[~2022-01-26 8:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 2:18 [PATCHSET 0/4] vfs: actually return fs errors from ->sync_fs Darrick J. Wong
2022-01-26 2:18 ` [PATCH 1/4] vfs: make freeze_super abort when sync_filesystem returns error Darrick J. Wong
2022-01-26 10:43 ` Jan Kara
2022-01-26 17:01 ` Christoph Hellwig
2022-01-26 2:18 ` [PATCH 2/4] vfs: make sync_filesystem return errors from ->sync_fs Darrick J. Wong
2022-01-26 10:44 ` Jan Kara
2022-01-26 17:01 ` Christoph Hellwig
2022-01-26 2:18 ` [PATCH 3/4] quota: make dquot_quota_sync " Darrick J. Wong
2022-01-26 10:45 ` Jan Kara
2022-01-26 17:03 ` Christoph Hellwig
2022-01-26 2:18 ` [PATCH 4/4] xfs: return errors in xfs_fs_sync_fs Darrick J. Wong
2022-01-26 10:45 ` Jan Kara
2022-01-26 17:03 ` Christoph Hellwig
2022-01-26 8:21 ` Christian Brauner [this message]
2022-01-26 18:05 ` [PATCHSET 0/4] vfs: actually return fs errors from ->sync_fs Darrick J. Wong
2022-01-27 9:11 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126082153.mz5prdistkkvc6bc@wittgenstein \
--to=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).