From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37ABFC433F5 for ; Mon, 7 Feb 2022 07:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239478AbiBGG5v (ORCPT ); Mon, 7 Feb 2022 01:57:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233171AbiBGGv4 (ORCPT ); Mon, 7 Feb 2022 01:51:56 -0500 X-Greylist: delayed 79 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 06 Feb 2022 22:51:55 PST Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43879C043181 for ; Sun, 6 Feb 2022 22:51:55 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 91DB468BFE; Mon, 7 Feb 2022 07:51:52 +0100 (CET) Date: Mon, 7 Feb 2022 07:51:52 +0100 From: Christoph Hellwig To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Seth Forshee , Christoph Hellwig , Al Viro Subject: Re: [PATCH 4/7] fs: add mnt_allow_writers() and simplify mount_setattr_prepare() Message-ID: <20220207065152.GD23601@lst.de> References: <20220203131411.3093040-1-brauner@kernel.org> <20220203131411.3093040-5-brauner@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220203131411.3093040-5-brauner@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Feb 03, 2022 at 02:14:08PM +0100, Christian Brauner wrote: > Add a tiny helper that lets us simplify the control-flow and can be used > in the next patch to avoid adding another condition open-coded into > mount_setattr_prepare(). Instead we can add it into the new helper. Looks good, Reviewed-by: Christoph Hellwig