* [PATCH] exec: cleanup comments
@ 2022-02-11 16:09 trix
2022-02-11 17:12 ` Randy Dunlap
2022-02-14 19:31 ` Kees Cook
0 siblings, 2 replies; 3+ messages in thread
From: trix @ 2022-02-11 16:09 UTC (permalink / raw)
To: ebiederm, keescook, viro; +Cc: linux-fsdevel, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
Remove the second 'from'.
Replace 'backwords' with 'backwards'.
Replace 'visibile' with 'visible'.
Signed-off-by: Tom Rix <trix@redhat.com>
---
fs/exec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/exec.c b/fs/exec.c
index 40b1008fb0f7..8256e8bb9ad3 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -118,7 +118,7 @@ bool path_noexec(const struct path *path)
* Note that a shared library must be both readable and executable due to
* security reasons.
*
- * Also note that we take the address to load from from the file itself.
+ * Also note that we take the address to load from the file itself.
*/
SYSCALL_DEFINE1(uselib, const char __user *, library)
{
@@ -542,7 +542,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
if (!valid_arg_len(bprm, len))
goto out;
- /* We're going to work our way backwords. */
+ /* We're going to work our way backwards. */
pos = bprm->p;
str += len;
bprm->p -= len;
@@ -1275,7 +1275,7 @@ int begin_new_exec(struct linux_binprm * bprm)
/*
* Must be called _before_ exec_mmap() as bprm->mm is
- * not visibile until then. This also enables the update
+ * not visible until then. This also enables the update
* to be lockless.
*/
retval = set_mm_exe_file(bprm->mm, bprm->file);
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] exec: cleanup comments
2022-02-11 16:09 [PATCH] exec: cleanup comments trix
@ 2022-02-11 17:12 ` Randy Dunlap
2022-02-14 19:31 ` Kees Cook
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-02-11 17:12 UTC (permalink / raw)
To: trix, ebiederm, keescook, viro; +Cc: linux-fsdevel, linux-kernel
On 2/11/22 08:09, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Remove the second 'from'.
> Replace 'backwords' with 'backwards'.
> Replace 'visibile' with 'visible'.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> fs/exec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/exec.c b/fs/exec.c
> index 40b1008fb0f7..8256e8bb9ad3 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -118,7 +118,7 @@ bool path_noexec(const struct path *path)
> * Note that a shared library must be both readable and executable due to
> * security reasons.
> *
> - * Also note that we take the address to load from from the file itself.
> + * Also note that we take the address to load from the file itself.
> */
> SYSCALL_DEFINE1(uselib, const char __user *, library)
> {
> @@ -542,7 +542,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
> if (!valid_arg_len(bprm, len))
> goto out;
>
> - /* We're going to work our way backwords. */
> + /* We're going to work our way backwards. */
> pos = bprm->p;
> str += len;
> bprm->p -= len;
> @@ -1275,7 +1275,7 @@ int begin_new_exec(struct linux_binprm * bprm)
>
> /*
> * Must be called _before_ exec_mmap() as bprm->mm is
> - * not visibile until then. This also enables the update
> + * not visible until then. This also enables the update
> * to be lockless.
> */
> retval = set_mm_exe_file(bprm->mm, bprm->file);
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] exec: cleanup comments
2022-02-11 16:09 [PATCH] exec: cleanup comments trix
2022-02-11 17:12 ` Randy Dunlap
@ 2022-02-14 19:31 ` Kees Cook
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2022-02-14 19:31 UTC (permalink / raw)
To: viro, trix, ebiederm; +Cc: Kees Cook, linux-fsdevel, linux-kernel
On Fri, 11 Feb 2022 08:09:40 -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Remove the second 'from'.
> Replace 'backwords' with 'backwards'.
> Replace 'visibile' with 'visible'.
>
>
> [...]
Applied to for-next/execve, thanks!
[1/1] exec: cleanup comments
https://git.kernel.org/kees/c/92eec5b2f7b8
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-14 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-11 16:09 [PATCH] exec: cleanup comments trix
2022-02-11 17:12 ` Randy Dunlap
2022-02-14 19:31 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).