From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D29C433EF for ; Wed, 23 Feb 2022 12:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240411AbiBWMSM (ORCPT ); Wed, 23 Feb 2022 07:18:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237095AbiBWMSM (ORCPT ); Wed, 23 Feb 2022 07:18:12 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1B7D9E57D; Wed, 23 Feb 2022 04:17:44 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id AF7AD212B8; Wed, 23 Feb 2022 12:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1645618663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z25zmfa1BH9FbZAkPcAjAOIvBZxhio/HEtOcbGxkK2s=; b=iBLlmwQKBfdGXCAAeg3wvlnrV4J7/udoMQQsDdu2Cee3a60Gai9m9bpGPUSAITEkoMaU8s 1//GkQuJVdkXZW2F3rLTgCANQjuKMwtQWqcfgugd/zWATYwJ3OL5tTae/rSTpI2MgrUQn2 85bOgy9hMuJpJjjUpIHA/9zHbWWnRZ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1645618663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z25zmfa1BH9FbZAkPcAjAOIvBZxhio/HEtOcbGxkK2s=; b=XIUgtLKy3brznIghNde4scldLLjKyFNVYfgKgSPS1OgKLfn3fJyCKSDJsMuABr1N7A2HJi gggIq5wSLuuz1jCw== Received: from quack3.suse.cz (unknown [10.163.28.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id A0D3BA3B83; Wed, 23 Feb 2022 12:17:43 +0000 (UTC) Received: by quack3.suse.cz (Postfix, from userid 1000) id E6B50A0605; Wed, 23 Feb 2022 13:17:37 +0100 (CET) Date: Wed, 23 Feb 2022 13:17:37 +0100 From: Jan Kara To: Matthew Wilcox Cc: Jan Kara , Edward Shishkin , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH] reiserfs: get rid of AOP_FLAG_CONT_EXPAND flag Message-ID: <20220223121737.bsyoih6rt63pev54@quack3.lan> References: <20220220232219.1235-1-edward.shishkin@gmail.com> <20220222102727.2sqf4wfdtjaxrqat@quack3.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue 22-02-22 13:38:19, Matthew Wilcox wrote: > On Tue, Feb 22, 2022 at 11:27:27AM +0100, Jan Kara wrote: > > On Mon 21-02-22 00:22:19, Edward Shishkin wrote: > > > Signed-off-by: Edward Shishkin > > > --- > > > fs/reiserfs/inode.c | 16 +++++----------- > > > 1 file changed, 5 insertions(+), 11 deletions(-) > > > > Thanks! I have queued this patch into my tree. > > I added the following commit message to it for my tree: > > Author: Edward Shishkin > Date: Mon Feb 21 00:22:19 2022 +0100 > > reiserfs: Stop using AOP_FLAG_CONT_EXPAND flag > > We can simplify write_begin() and write_end() by handling the > cont_expand case in reiserfs_setattr(). > > Signed-off-by: Edward Shishkin > Signed-off-by: Matthew Wilcox (Oracle) Yeah, I have written some changelog as well :) Something like: reiserfs: get rid of AOP_FLAG_CONT_EXPAND flag Remove usage of AOP_FLAG_CONT_EXPAND flag. Reiserfs is the only user of it and it is easy to avoid. Link: https://lore.kernel.org/r/20220220232219.1235-1-edward.shishkin@gmail.com Signed-off-by: Edward Shishkin Signed-off-by: Jan Kara > I don't object if it goes via your tree; I doubt I'll get the AOP_FLAG > removal finished in time for the next merge window. OK, I'll keep it in my tree then and push it to Linus for the merge window. Honza -- Jan Kara SUSE Labs, CR