From: Stefan Roesch <shr@fb.com>
To: <io-uring@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<kernel-team@fb.com>
Cc: <viro@zeniv.linux.org.uk>, <shr@fb.com>, <rostedt@goodmis.org>,
<m.szyprowski@samsung.com>
Subject: [PATCH v4 0/1] io-uring: Make statx api stable
Date: Fri, 25 Feb 2022 10:53:25 -0800 [thread overview]
Message-ID: <20220225185326.1373304-1-shr@fb.com> (raw)
One of the key architectual tenets of io-uring is to keep the
parameters for io-uring stable. After the call has been submitted,
its value can be changed. Unfortunaltely this is not the case for
the current statx implementation.
Patch:
Part 1: fs: replace const char* parameter in vfs_statx and do_statx with
struct filename
Create filename object outside of do_statx and vfs_statx, so io-uring
can create the filename object during the prepare phase
Part 2: io-uring: Copy path name during prepare stage for statx
Create and store filename object during prepare phase
There is also a patch for the liburing libray to add a new test case. This
patch makes sure that the api is stable.
"liburing: add test for stable statx api"
The patch has been tested with the liburing test suite and fstests.
Changes:
V2: don't check name in vfs_fstatat
V3: don't check name in statx syscall
V4: - incorporate Steven Rostedt's fix
- Merge both patches to avoid bisect problem
(the io-uring changes have a dependency on the parameter change in
the fs layer)
Stefan Roesch (1):
io-uring: Make statx API stable
fs/internal.h | 4 +++-
fs/io_uring.c | 22 ++++++++++++++++++++--
fs/stat.c | 49 +++++++++++++++++++++++++++++++++++--------------
3 files changed, 58 insertions(+), 17 deletions(-)
base-commit: 5c1ee569660d4a205dced9cb4d0306b907fb7599
--
2.30.2
next reply other threads:[~2022-02-25 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 18:53 Stefan Roesch [this message]
2022-02-25 18:53 ` [PATCH v4 1/1] io-uring: Make statx API stable Stefan Roesch
2022-02-26 20:01 ` Luis Chamberlain
2022-02-25 20:30 ` [PATCH v4 0/1] io-uring: Make statx api stable Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225185326.1373304-1-shr@fb.com \
--to=shr@fb.com \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).