linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Muchun Song <songmuchun@bytedance.com>
To: willy@infradead.org, akpm@linux-foundation.org,
	hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com,
	shakeelb@google.com, roman.gushchin@linux.dev,
	shy828301@gmail.com, alexs@kernel.org, richard.weiyang@gmail.com,
	david@fromorbit.com, trond.myklebust@hammerspace.com,
	anna.schumaker@netapp.com, jaegeuk@kernel.org, chao@kernel.org,
	kari.argillander@gmail.com, vbabka@suse.cz
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-nfs@vger.kernel.org,
	zhengqi.arch@bytedance.com, duanxiongchun@bytedance.com,
	fam.zheng@bytedance.com, smuchun@gmail.com,
	Muchun Song <songmuchun@bytedance.com>
Subject: [PATCH v6 03/16] fs: introduce alloc_inode_sb() to allocate filesystems specific inode
Date: Mon, 28 Feb 2022 20:21:13 +0800	[thread overview]
Message-ID: <20220228122126.37293-4-songmuchun@bytedance.com> (raw)
In-Reply-To: <20220228122126.37293-1-songmuchun@bytedance.com>

The allocated inode cache is supposed to be added to its memcg list_lru
which should be allocated as well in advance. That can be done by
kmem_cache_alloc_lru() which allocates object and list_lru. The file
systems is main user of it. So introduce alloc_inode_sb() to allocate
file system specific inodes and set up the inode reclaim context
properly. The file system is supposed to use alloc_inode_sb() to
allocate inodes. In the later patches, we will convert all users to the
new API.

Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
---
 Documentation/filesystems/porting.rst |  6 ++++++
 fs/inode.c                            |  2 +-
 include/linux/fs.h                    | 11 +++++++++++
 3 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
index bf19fd6b86e7..7c1583dbeb59 100644
--- a/Documentation/filesystems/porting.rst
+++ b/Documentation/filesystems/porting.rst
@@ -45,6 +45,12 @@ typically between calling iget_locked() and unlocking the inode.
 
 At some point that will become mandatory.
 
+**mandatory**
+
+The foo_inode_info should always be allocated through alloc_inode_sb() rather
+than kmem_cache_alloc() or kmalloc() related to set up the inode reclaim context
+correctly.
+
 ---
 
 **mandatory**
diff --git a/fs/inode.c b/fs/inode.c
index 63324df6fa27..9d9b422504d1 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -259,7 +259,7 @@ static struct inode *alloc_inode(struct super_block *sb)
 	if (ops->alloc_inode)
 		inode = ops->alloc_inode(sb);
 	else
-		inode = kmem_cache_alloc(inode_cachep, GFP_KERNEL);
+		inode = alloc_inode_sb(sb, inode_cachep, GFP_KERNEL);
 
 	if (!inode)
 		return NULL;
diff --git a/include/linux/fs.h b/include/linux/fs.h
index e2d892b201b0..3d56b02667f4 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -42,6 +42,7 @@
 #include <linux/mount.h>
 #include <linux/cred.h>
 #include <linux/mnt_idmapping.h>
+#include <linux/slab.h>
 
 #include <asm/byteorder.h>
 #include <uapi/linux/fs.h>
@@ -3108,6 +3109,16 @@ extern void free_inode_nonrcu(struct inode *inode);
 extern int should_remove_suid(struct dentry *);
 extern int file_remove_privs(struct file *);
 
+/*
+ * This must be used for allocating filesystems specific inodes to set
+ * up the inode reclaim context correctly.
+ */
+static inline void *
+alloc_inode_sb(struct super_block *sb, struct kmem_cache *cache, gfp_t gfp)
+{
+	return kmem_cache_alloc_lru(cache, &sb->s_inode_lru, gfp);
+}
+
 extern void __insert_inode_hash(struct inode *, unsigned long hashval);
 static inline void insert_inode_hash(struct inode *inode)
 {
-- 
2.11.0


  parent reply	other threads:[~2022-02-28 12:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 12:21 [PATCH v6 00/16] Optimize list lru memory consumption Muchun Song
2022-02-28 12:21 ` [PATCH v6 01/16] mm: list_lru: transpose the array of per-node per-memcg lru lists Muchun Song
2022-02-28 12:21 ` [PATCH v6 02/16] mm: introduce kmem_cache_alloc_lru Muchun Song
2022-02-28 12:21 ` Muchun Song [this message]
2022-02-28 12:21 ` [PATCH v6 04/16] fs: allocate inode by using alloc_inode_sb() Muchun Song
2022-02-28 12:21 ` [PATCH v6 05/16] f2fs: " Muchun Song
2022-02-28 12:21 ` [PATCH v6 06/16] nfs42: use a specific kmem_cache to allocate nfs4_xattr_entry Muchun Song
2022-02-28 12:21 ` [PATCH v6 07/16] mm: dcache: use kmem_cache_alloc_lru() to allocate dentry Muchun Song
2022-02-28 12:21 ` [PATCH v6 08/16] xarray: use kmem_cache_alloc_lru to allocate xa_node Muchun Song
2022-02-28 12:21 ` [PATCH v6 09/16] mm: memcontrol: move memcg_online_kmem() to mem_cgroup_css_online() Muchun Song
2022-02-28 12:21 ` [PATCH v6 10/16] mm: list_lru: allocate list_lru_one only when needed Muchun Song
2022-02-28 12:21 ` [PATCH v6 11/16] mm: list_lru: rename memcg_drain_all_list_lrus to memcg_reparent_list_lrus Muchun Song
2022-02-28 12:21 ` [PATCH v6 12/16] mm: list_lru: replace linear array with xarray Muchun Song
2022-03-31  3:26   ` NeilBrown
2022-03-31  3:52     ` Muchun Song
2022-03-31  4:24       ` NeilBrown
2022-03-31  6:16         ` Muchun Song
2022-03-31 22:36           ` NeilBrown
2022-04-01  2:29             ` Muchun Song
2022-03-31 15:01   ` Matthew Wilcox
2022-04-01  3:23     ` Muchun Song
2022-02-28 12:21 ` [PATCH v6 13/16] mm: memcontrol: reuse memory cgroup ID for kmem ID Muchun Song
2022-02-28 12:21 ` [PATCH v6 14/16] mm: memcontrol: fix cannot alloc the maximum memcg ID Muchun Song
2022-02-28 12:21 ` [PATCH v6 15/16] mm: list_lru: rename list_lru_per_memcg to list_lru_memcg Muchun Song
2022-02-28 12:21 ` [PATCH v6 16/16] mm: memcontrol: rename memcg_cache_id to memcg_kmem_id Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220228122126.37293-4-songmuchun@bytedance.com \
    --to=songmuchun@bytedance.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexs@kernel.org \
    --cc=anna.schumaker@netapp.com \
    --cc=chao@kernel.org \
    --cc=david@fromorbit.com \
    --cc=duanxiongchun@bytedance.com \
    --cc=fam.zheng@bytedance.com \
    --cc=hannes@cmpxchg.org \
    --cc=jaegeuk@kernel.org \
    --cc=kari.argillander@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=richard.weiyang@gmail.com \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeelb@google.com \
    --cc=shy828301@gmail.com \
    --cc=smuchun@gmail.com \
    --cc=trond.myklebust@hammerspace.com \
    --cc=vbabka@suse.cz \
    --cc=vdavydov.dev@gmail.com \
    --cc=willy@infradead.org \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).