From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
sagi@grimberg.me, kbusch@kernel.org, song@kernel.org,
linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] block: remove the per-bio/request write hint
Date: Sun, 6 Mar 2022 19:01:15 +0100 [thread overview]
Message-ID: <20220306180115.GA8777@lst.de> (raw)
In-Reply-To: <2241127c-c600-529a-ae41-30cbcc6b281d@kernel.dk>
On Sun, Mar 06, 2022 at 10:11:46AM -0700, Jens Axboe wrote:
> Yes, I think we should kill it. If we retain the inode hint, the f2fs
> doesn't need a any changes. And it should be safe to make the per-file
> fcntl hints return EINVAL, which they would on older kernels anyway.
> Untested, but something like the below.
I've sent this off to the testing farm this morning, but EINVAL might
be even better:
http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/more-hint-removal
next prev parent reply other threads:[~2022-03-06 18:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 17:55 [PATCH 1/2] nvme: remove support or stream based temperature hint Christoph Hellwig
2022-03-04 17:55 ` [PATCH 2/2] block: remove the per-bio/request write hint Christoph Hellwig
2022-03-04 19:24 ` Jens Axboe
2022-03-04 22:12 ` Dave Chinner
2022-03-05 5:19 ` Christoph Hellwig
2022-03-05 21:40 ` Dave Chinner
2022-03-05 23:55 ` Bart Van Assche
2022-03-06 17:11 ` Jens Axboe
2022-03-06 18:01 ` Christoph Hellwig [this message]
2022-03-06 18:06 ` Jens Axboe
2022-03-06 23:17 ` Dave Chinner
[not found] ` <CGME20220309042324epcas1p111312e20f4429dc3a17172458284a923@epcas1p1.samsung.com>
2022-03-09 13:31 ` Manjong Lee
2022-03-09 8:24 ` Paul Menzel
2022-03-10 11:34 ` [EXT] " Luca Porzio (lporzio)
2022-03-10 12:15 ` Jens Axboe
2022-03-10 18:50 ` Luca Porzio (lporzio)
2022-03-10 19:10 ` Jens Axboe
2022-03-10 19:34 ` Bart Van Assche
2022-03-10 21:52 ` Bean Huo (beanhuo)
2022-03-10 22:10 ` Jens Axboe
2022-03-11 16:45 ` Bart Van Assche
2022-03-11 16:56 ` Jens Axboe
2022-03-14 7:40 ` Avi Shchislowski
2022-03-14 8:00 ` hch
2022-03-14 19:50 ` Eric Biggers
2022-03-14 19:58 ` [EXT] " Jens Axboe
2022-03-15 15:36 ` Luca Porzio (lporzio)
2022-03-15 15:44 ` Jens Axboe
2022-03-10 22:18 ` Bart Van Assche
2022-03-11 5:31 ` Eric Biggers
2022-03-11 9:21 ` Luca Porzio (lporzio)
2022-03-10 14:21 ` hch
2022-03-10 18:51 ` Luca Porzio (lporzio)
2022-03-10 19:14 ` hch
2022-03-11 5:06 ` Eric Biggers
2022-03-11 9:23 ` Luca Porzio (lporzio)
2022-03-04 19:34 ` [PATCH 1/2] nvme: remove support or stream based temperature hint Keith Busch
2022-03-04 19:36 ` Christoph Hellwig
2022-03-04 19:38 ` Jens Axboe
2022-03-04 20:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220306180115.GA8777@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).