From: Colin Ian King <colin.i.king@gmail.com>
To: David Sterba <dsterba@suse.com>, linux-fsdevel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fs/affs: remove redundant assignment to ch
Date: Mon, 7 Mar 2022 15:07:42 +0000 [thread overview]
Message-ID: <20220307150742.137873-1-colin.i.king@gmail.com> (raw)
The assignment of ch after subtracting ('a' - 'A') is redundant and
can be removed. Fix this by replacing the -= operator with just -
to remove the assignment.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/affs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/affs/namei.c b/fs/affs/namei.c
index bcab18956b4f..a1270deba908 100644
--- a/fs/affs/namei.c
+++ b/fs/affs/namei.c
@@ -19,7 +19,7 @@ typedef int (*toupper_t)(int);
static int
affs_toupper(int ch)
{
- return ch >= 'a' && ch <= 'z' ? ch -= ('a' - 'A') : ch;
+ return ch >= 'a' && ch <= 'z' ? ch - ('a' - 'A') : ch;
}
/* International toupper() for DOS\3 ("international") */
--
2.35.1
next reply other threads:[~2022-03-07 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 15:07 Colin Ian King [this message]
2022-03-29 16:51 ` [PATCH] fs/affs: remove redundant assignment to ch David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307150742.137873-1-colin.i.king@gmail.com \
--to=colin.i.king@gmail.com \
--cc=dsterba@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).