From: Christian Brauner <brauner@kernel.org>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org,
viro@zeniv.linux.org.uk, david@fromorbit.com, jlayton@kernel.org
Subject: Re: [PATCH v1 1/3] vfs: Add inode_sgid_strip() api
Date: Tue, 29 Mar 2022 12:45:16 +0200 [thread overview]
Message-ID: <20220329104516.luheugjurxsx5fdq@wittgenstein> (raw)
In-Reply-To: <1648461389-2225-1-git-send-email-xuyang2018.jy@fujitsu.com>
On Mon, Mar 28, 2022 at 05:56:27PM +0800, Yang Xu wrote:
> inode_sgid_strip() function is used to strip S_ISGID mode
> when creat/open/mknod file.
>
> Suggested-by: Dave Chinner <david@fromorbit.com>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
I would've personally gone for returning umode_t but this work for me
too.
Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
next prev parent reply other threads:[~2022-03-29 10:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 9:56 [PATCH v1 1/3] vfs: Add inode_sgid_strip() api Yang Xu
2022-03-28 9:56 ` [PATCH v1 2/3] vfs: strip file's S_ISGID mode on vfs instead of on filesystem Yang Xu
2022-03-29 11:08 ` Christian Brauner
2022-03-29 11:12 ` Jeff Layton
2022-03-29 22:10 ` Dave Chinner
2022-03-30 10:44 ` Christian Brauner
2022-03-30 16:44 ` Darrick J. Wong
2022-03-31 9:30 ` xuyang2018.jy
2022-03-29 10:45 ` Christian Brauner [this message]
2022-03-29 22:15 ` [PATCH v1 1/3] vfs: Add inode_sgid_strip() api Dave Chinner
2022-03-30 16:34 ` Darrick J. Wong
2022-03-31 1:49 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329104516.luheugjurxsx5fdq@wittgenstein \
--to=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox