From: Bruce Fields <bfields@fieldses.org>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: Dai Ngo <dai.ngo@oracle.com>, Jeff Layton <jlayton@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC v18 02/11] NFSD: Add courtesy client state, macro and spinlock to support courteous server
Date: Tue, 29 Mar 2022 16:01:27 -0400 [thread overview]
Message-ID: <20220329200127.GE32217@fieldses.org> (raw)
In-Reply-To: <ACF56E81-BAB9-4102-A4C3-AB03DE1BAE76@oracle.com>
On Tue, Mar 29, 2022 at 07:58:46PM +0000, Chuck Lever III wrote:
> Got it. Agreed, cl_cs_client_state should be reinitialized if
> a courtesy client is transitioned back to "active".
>
> Dai, would you add
>
> +enum courtesy_client_state {
> >>> NFSD4_CLIENT_ACTIVE = 0,
> + NFSD4_CLIENT_COURTESY,
> + NFSD4_CLIENT_EXPIRED,
> + NFSD4_CLIENT_RECONNECTED,
> +};
>
> And set cl_cs_client_state to ACTIVE where the client is
> allowed to transition back to being active?
I'm not clear then what the RECONNECTED->ACTIVE transition would be.
My feeling is that the RECONNECTED state shouldn't exist, and that there
should only be a transition of EXPIRED back to ACTIVE.
--b.
next prev parent reply other threads:[~2022-03-29 20:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 4:34 [PATCH RFC v18 0/11] NFSD: Initial implementation of NFSv4 Courteous Server Dai Ngo
2022-03-25 4:34 ` [PATCH RFC v18 01/11] fs/lock: add helper locks_owner_has_blockers to check for blockers Dai Ngo
2022-03-25 4:34 ` [PATCH RFC v18 02/11] NFSD: Add courtesy client state, macro and spinlock to support courteous server Dai Ngo
2022-03-29 15:47 ` J. Bruce Fields
2022-03-29 16:20 ` dai.ngo
2022-03-29 16:30 ` J. Bruce Fields
2022-03-29 16:42 ` J. Bruce Fields
2022-03-29 18:19 ` dai.ngo
2022-03-29 18:39 ` J. Bruce Fields
2022-03-29 19:32 ` Chuck Lever III
2022-03-29 19:49 ` Bruce Fields
2022-03-29 19:58 ` Chuck Lever III
2022-03-29 20:01 ` Bruce Fields [this message]
2022-03-29 20:20 ` Chuck Lever III
2022-03-29 20:50 ` dai.ngo
2022-03-29 21:45 ` dai.ngo
2022-03-30 0:12 ` J. Bruce Fields
2022-03-30 1:17 ` dai.ngo
2022-03-30 1:48 ` J. Bruce Fields
2022-03-25 4:34 ` [PATCH RFC v18 03/11] NFSD: Add lm_lock_expired call out Dai Ngo
2022-03-25 4:34 ` [PATCH RFC v18 04/11] NFSD: Update nfsd_breaker_owns_lease() to handle courtesy clients Dai Ngo
2022-03-25 4:34 ` [PATCH RFC v18 05/11] NFSD: Update nfs4_get_vfs_file() to handle courtesy client Dai Ngo
2022-03-29 15:24 ` J. Bruce Fields
2022-03-29 16:06 ` dai.ngo
2022-03-29 16:11 ` J. Bruce Fields
2022-03-25 4:34 ` [PATCH RFC v18 06/11] NFSD: Update find_clp_in_name_tree() " Dai Ngo
2022-03-25 4:34 ` [PATCH RFC v18 07/11] NFSD: Update find_in_sessionid_hashtbl() " Dai Ngo
2022-03-25 4:34 ` [PATCH RFC v18 08/11] NFSD: Update find_client_in_id_table() " Dai Ngo
2022-03-25 4:34 ` [PATCH RFC v18 09/11] NFSD: Refactor nfsd4_laundromat() Dai Ngo
2022-03-25 4:34 ` [PATCH RFC v18 10/11] NFSD: Update laundromat to handle courtesy clients Dai Ngo
2022-03-25 4:34 ` [PATCH RFC v18 11/11] NFSD: Show state of courtesy clients in client info Dai Ngo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329200127.GE32217@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).