linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
To: corbet@lwn.net, mcgrof@kernel.org, keescook@chromium.org,
	yzaikin@google.com, linux-fsdevel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, linux@rasmusvillemoes.dk,
	ebiggers@google.com, peterz@infradead.org, ying.huang@intel.com,
	gpiccoli@igalia.com, mchehab+huawei@kernel.org, Jason@zx2c4.com,
	daniel@iogearbox.net, robh@kernel.org, wangqing@vivo.com,
	prestwoj@gmail.com, dsahern@kernel.org,
	stephen.s.brennan@oracle.com, alejandro.j.jimenez@oracle.com
Subject: [RFC 0/1] Add sysctl entry for controlling crash_kexec_post_notifiers
Date: Fri,  1 Apr 2022 16:22:59 -0400	[thread overview]
Message-ID: <20220401202300.12660-1-alejandro.j.jimenez@oracle.com> (raw)

I noticed that in contrast to other kernel core parameters (e.g. kernel.panic,
kernel.panic_on_warn, kernel.panic_print) crash_kexec_post_notifiers is not
available as a sysctl tunable. I am aware that because it is a kernel core
parameter, there is already an entry under:

  /sys/module/kernel/parameters/crash_kexec_post_notifiers

and that allows us to read/modify it at runtime. However, I thought it should
also be available via sysctl, since users that want to read/set this value at
runtime might look there first.

I believe there is an ongoing effort to clean up kernel/sysctl.c, but it wasn't
clear to me if this entry (and perhaps the other panic related entries too)
should be placed on kernel/panic.c. I wanted to verify first that this change
would be welcomed before doing additional refactoring work.

I'd appreciate any comments or suggestions.

Thank you,
Alejandro

Alejandro Jimenez (1):
  kernel/sysctl: Add sysctl entry for crash_kexec_post_notifiers

 Documentation/admin-guide/sysctl/kernel.rst | 8 ++++++++
 include/uapi/linux/sysctl.h                 | 1 +
 kernel/sysctl.c                             | 7 +++++++
 3 files changed, 16 insertions(+)

-- 
2.34.1


             reply	other threads:[~2022-04-01 20:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01 20:22 Alejandro Jimenez [this message]
2022-04-01 20:23 ` [RFC 1/1] kernel/sysctl: Add sysctl entry for crash_kexec_post_notifiers Alejandro Jimenez
2022-04-01 21:35   ` Luis Chamberlain
2022-04-02 14:01 ` [RFC 0/1] Add sysctl entry for controlling crash_kexec_post_notifiers Guilherme G. Piccoli
2022-04-04 20:43   ` Alejandro Jimenez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401202300.12660-1-alejandro.j.jimenez@oracle.com \
    --to=alejandro.j.jimenez@oracle.com \
    --cc=Jason@zx2c4.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@kernel.org \
    --cc=ebiggers@google.com \
    --cc=gpiccoli@igalia.com \
    --cc=keescook@chromium.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mcgrof@kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=peterz@infradead.org \
    --cc=prestwoj@gmail.com \
    --cc=robh@kernel.org \
    --cc=stephen.s.brennan@oracle.com \
    --cc=wangqing@vivo.com \
    --cc=ying.huang@intel.com \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).