From: Yang Li <yang.lee@linux.alibaba.com>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: [PATCH -next] vfs: fs_context: Fix some kernel-doc comments
Date: Sat, 2 Apr 2022 16:22:22 +0800 [thread overview]
Message-ID: <20220402082222.114428-1-yang.lee@linux.alibaba.com> (raw)
Remove some warnings found by running scripts/kernel-doc,
which is caused by using 'make W=1'.
fs/fs_context.c:202: warning: Function parameter or member 'fc' not
described in 'generic_parse_monolithic'
fs/fs_context.c:202: warning: Excess function parameter 'ctx'
description in 'generic_parse_monolithic'
fs/fs_context.c:340: warning: expecting prototype for
vfs_dup_fc_config(). Prototype was for vfs_dup_fs_context() instead
fs/fs_context.c:386: warning: Function parameter or member 'log' not
described in 'logfc'
fs/fs_context.c:386: warning: Function parameter or member 'prefix' not
described in 'logfc'
fs/fs_context.c:386: warning: Function parameter or member 'level' not
described in 'logfc'
fs/fs_context.c:386: warning: Excess function parameter 'fc' description
in 'logfc'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
fs/fs_context.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/fs_context.c b/fs/fs_context.c
index 24ce12f0db32..be2bce5fe66d 100644
--- a/fs/fs_context.c
+++ b/fs/fs_context.c
@@ -189,7 +189,8 @@ EXPORT_SYMBOL(vfs_parse_fs_string);
/**
* generic_parse_monolithic - Parse key[=val][,key[=val]]* mount data
- * @ctx: The superblock configuration to fill in.
+ * @fc: Filesystem context for holding the parameters used in the creation or
+ * reconfiguration of a superblock.
* @data: The data to parse
*
* Parse a blob of data that's in key[=val][,key[=val]]* form. This can be
@@ -333,7 +334,7 @@ void fc_drop_locked(struct fs_context *fc)
static void legacy_fs_context_free(struct fs_context *fc);
/**
- * vfs_dup_fc_config: Duplicate a filesystem context.
+ * vfs_dup_fs_context: Duplicate a filesystem context.
* @src_fc: The context to copy.
*/
struct fs_context *vfs_dup_fs_context(struct fs_context *src_fc)
@@ -379,7 +380,9 @@ EXPORT_SYMBOL(vfs_dup_fs_context);
/**
* logfc - Log a message to a filesystem context
- * @fc: The filesystem context to log to.
+ * @log: The filesystem context to log to.
+ * @prefix: The log prefix.
+ * @level: The log level.
* @fmt: The format of the buffer.
*/
void logfc(struct fc_log *log, const char *prefix, char level, const char *fmt, ...)
--
2.20.1.7.g153144c
reply other threads:[~2022-04-02 8:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220402082222.114428-1-yang.lee@linux.alibaba.com \
--to=yang.lee@linux.alibaba.com \
--cc=abaci@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).