From: Christian Brauner <brauner@kernel.org>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: david@fromorbit.com, djwong@kernel.org,
linux-fsdevel@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH v2 3/6] idmapped-mounts: Reset errno to zero after detect fs_allow_idmap
Date: Thu, 7 Apr 2022 14:59:36 +0200 [thread overview]
Message-ID: <20220407125936.hxp5oqddxpbtb27w@wittgenstein> (raw)
In-Reply-To: <1649333375-2599-3-git-send-email-xuyang2018.jy@fujitsu.com>
On Thu, Apr 07, 2022 at 08:09:32PM +0800, Yang Xu wrote:
> If we run case on old kernel that doesn't support mount_setattr and
> then fail on our own function before call is_setgid/is_setuid function
> to reset errno, run_test will print "Function not implement" error.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
> src/idmapped-mounts/idmapped-mounts.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/idmapped-mounts/idmapped-mounts.c b/src/idmapped-mounts/idmapped-mounts.c
> index e8a856de..d2638c64 100644
> --- a/src/idmapped-mounts/idmapped-mounts.c
> +++ b/src/idmapped-mounts/idmapped-mounts.c
> @@ -14254,6 +14254,8 @@ int main(int argc, char *argv[])
> die("failed to open %s", t_mountpoint_scratch);
>
> t_fs_allow_idmap = fs_allow_idmap();
> + /*Don't copy ENOSYS errno to child proecss on older kernel*/
nit: s/proecess/process/
next prev parent reply other threads:[~2022-04-07 12:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 12:09 [PATCH v2 1/6] idmapped-mount: split setgid test from test-core Yang Xu
2022-04-07 12:09 ` [PATCH v2 2/6] idmapped-mounts: Add mknodat operation in setgid test Yang Xu
2022-04-07 13:40 ` Christian Brauner
2022-04-08 3:02 ` xuyang2018.jy
2022-04-07 12:09 ` [PATCH v2 3/6] idmapped-mounts: Reset errno to zero after detect fs_allow_idmap Yang Xu
2022-04-07 12:59 ` Christian Brauner [this message]
2022-04-07 12:09 ` [PATCH v2 4/6] idmapped-mounts: Add umask(S_IXGRP) wrapper for setgid_create* cases Yang Xu
2022-04-07 15:12 ` Christian Brauner
2022-04-08 3:38 ` xuyang2018.jy
2022-04-07 12:09 ` [PATCH v2 5/6] idmapped-mounts: Add setfacl(S_IXGRP) " Yang Xu
2022-04-07 12:09 ` [PATCH v2 6/6] idmapped-mounts: Add open with O_TMPFILE operation in setgid test Yang Xu
2022-04-07 13:43 ` Christian Brauner
2022-04-08 3:58 ` xuyang2018.jy
2022-04-08 7:34 ` Zorro Lang
2022-04-08 7:55 ` xuyang2018.jy
2022-04-07 12:55 ` [PATCH v2 1/6] idmapped-mount: split setgid test from test-core Christian Brauner
2022-04-08 1:20 ` xuyang2018.jy
2022-04-08 10:17 ` xuyang2018.jy
2022-04-08 10:33 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407125936.hxp5oqddxpbtb27w@wittgenstein \
--to=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).