From: "Darrick J. Wong" <djwong@kernel.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Christoph Hellwig <hch@infradead.org>,
Dave Chinner <dchinner@redhat.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: update IOMAP FILESYSTEM LIBRARY and XFS FILESYSTEM
Date: Tue, 12 Apr 2022 15:47:20 -0700 [thread overview]
Message-ID: <20220412224720.GJ16799@magnolia> (raw)
In-Reply-To: <0d629b54-a29c-aeed-1330-840b1b98a8a3@loongson.cn>
On Tue, Apr 12, 2022 at 12:55:39PM +0800, Tiezhu Yang wrote:
>
>
> On 04/12/2022 11:50 AM, Darrick J. Wong wrote:
> > On Mon, Apr 11, 2022 at 08:39:17PM -0700, Darrick J. Wong wrote:
> > > On Tue, Apr 12, 2022 at 11:21:26AM +0800, Tiezhu Yang wrote:
> > > > Remove the following section entries of IOMAP FILESYSTEM LIBRARY:
> > > >
> > > > M: linux-xfs@vger.kernel.org
> > > > M: linux-fsdevel@vger.kernel.org
> > > >
> > > > Remove the following section entry of XFS FILESYSTEM:
> > > >
> > > > M: linux-xfs@vger.kernel.org
> > > >
> > > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > >
> > > WTF?
> > >
> > > ▄▄ ▄ ▄▄ ▄ ▄
> > > █▀▄ █ ██ █ ▄▀
> > > █ █▄ █ █ █ █▄█
> > > █ █ █ █▄▄█ █ █▄
> > > █ ██ █ █ █ ▀▄
> >
> > *OH*, I see, you're getting rid of the M(ail): entry, probably because
> > it's redundant with L(ist): or something?? Still... why does it matter?
>
> Yes, the section entries are redundant. Sorry for the unclear description.
>
> The intention of this patch is to clean up the redundant section entries.
>
> >
> > Seriously, changelogs need to say /why/ they're changing something, not
> > simply restate what's already in the diff.
>
> OK, thank you. Should I send a v2 patch to update the commit message
> or just ignore this patch?
Yes, please send a v2 patch with an improved commit message. NAK
withdrawn.
--D
> Thanks,
> Tiezhu
>
prev parent reply other threads:[~2022-04-12 23:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 3:21 [PATCH] MAINTAINERS: update IOMAP FILESYSTEM LIBRARY and XFS FILESYSTEM Tiezhu Yang
2022-04-12 3:39 ` Darrick J. Wong
2022-04-12 3:50 ` Darrick J. Wong
2022-04-12 4:55 ` Tiezhu Yang
2022-04-12 22:47 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412224720.GJ16799@magnolia \
--to=djwong@kernel.org \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).