From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1569C433FE for ; Thu, 14 Apr 2022 23:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234505AbiDNXaK (ORCPT ); Thu, 14 Apr 2022 19:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230002AbiDNXaJ (ORCPT ); Thu, 14 Apr 2022 19:30:09 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 522F43FD81 for ; Thu, 14 Apr 2022 16:27:40 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id t13so6049524pgn.8 for ; Thu, 14 Apr 2022 16:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HmZzQaJcWVmRJdxQhHXzNCOEJRKn8oL9PGuKLwC4Vpk=; b=d1VKqQJQtATMIHplVI4UJ3GOGV6h5gR9y1TJbLwrVNFwoDKD6c3KLTeTwWyhfX1b6/ bn2wbRksRbvFqps2Uu35fOeZnbu5K9rKtmY+viXPnznVSB3PctbOWHhOOVKsQHaCEU7B I4T6uDq4ftL4iKujE5TZsbCs9tuSrg5t8Ve7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HmZzQaJcWVmRJdxQhHXzNCOEJRKn8oL9PGuKLwC4Vpk=; b=OK9m4giHX2QTIX6Gd12iRvrRROooRM4Ozc6JDJRV4WL5uZpCg5mjT7+EJKtMObxfFQ lK+EPCsh5uYbvMlGv+6BbE+sjpyeFgu7PgSZ3ipwNmP/Y0UioesVZGnyOzKlGWOBE/SD GsYFw3PGdkAofOnC+h4qd+0mFfFq+wv4yxetRThP0pg2m8Q9Ao0aGB0bZ4x8hcgsMDAn wWYJYdlmCojGqKL5r4FASXNo6QGx7jV9XK573m0JukA2FDj5jug0uQsRocv1vEu/OZig U++i9FRzsQ4nbJha+IvhrILkw8GtsSGhs01oEyKL56n6xhqbTbxCYJ+WGcJdWKjyW8PW xzpQ== X-Gm-Message-State: AOAM532lXLQOWeYoSpJdeZrNlLralCur4pLspxAepotTz5HZDk+FDJH0 EWmbd/lmn6CK/2h7nB/qOFJGIg== X-Google-Smtp-Source: ABdhPJzq0A/ZN73+dcU0JnfCl1TVr6vkBK+NJGz++LvwQCH3lxWX0dgKyG5WwEKfaEtKzf1QfZl+4w== X-Received: by 2002:a63:3e88:0:b0:39d:ae86:237d with SMTP id l130-20020a633e88000000b0039dae86237dmr4132709pga.360.1649978859862; Thu, 14 Apr 2022 16:27:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e12-20020a056a0000cc00b00508343a6f9esm902728pfj.5.2022.04.14.16.27.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 16:27:39 -0700 (PDT) Date: Thu, 14 Apr 2022 16:27:38 -0700 From: Kees Cook To: Niklas Cassel , Konstantin Ryabitsev Cc: Alexander Viro , Eric Biederman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Greg Ungerer , Mike Frysinger , Damien Le Moal , stable@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2] binfmt_flat: do not stop relocating GOT entries prematurely on riscv Message-ID: <202204141624.6689D6B@keescook> References: <20220414091018.896737-1-niklas.cassel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220414091018.896737-1-niklas.cassel@wdc.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Apr 14, 2022 at 11:10:18AM +0200, Niklas Cassel wrote: > bFLT binaries are usually created using elf2flt. > [...] Hm, something in the chain broke DKIM, but I can't see what: ✗ [PATCH v2] binfmt_flat: do not stop relocating GOT entries prematurely on riscv ✗ BADSIG: DKIM/wdc.com Konstantin, do you have a process for debugging these? I don't see the "normal" stuff that breaks DKIM (i.e. a trailing mailing list footer, etc) -- Kees Cook