Re: [PATCH v2] binfmt_flat: do not stop relocating GOT entries prematurely on riscv

Niklas Cassel
2022-04-15T01:08:33Z

On Fri, Apr 15, 2022 at 09:56:38AM +0900, Damien Le Moal wrote:
> On 4/15/22 09:30, Niklas Cassel wrote:
> > On Fri, Apr 15, 2022 at 08:51:27AM +0900, Damien Le Moal wrote:
> >> On 4/14/22 18:10, Niklas Cassel wrote:

(snip)

> So if we are sure that we can just skip the first 16B/8B for riscv, I
> would not bother checking the header content. But as mentioned, the
> current code is fine too.

That was my point, I'm not sure that we can be sure that we can always
skip it in the future. E.g. if the elf2flt linker script decides to swap
the order of .got and .got.plt for some random reason in the future,
we would skip data that really should have been relocated.

So I think that it is better to keep it, even if it is a bit verbose.

Kind regards,
Niklas