From: Jakub Kicinski <kuba@kernel.org>
To: xiangxia.m.yue@gmail.com
Cc: netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Simon Horman <horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>, Shuah Khan <shuah@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Lorenz Bauer <lmb@cloudflare.com>,
Akhmat Karakotov <hmukos@yandex-team.ru>
Subject: Re: [net-next v4 3/3] selftests/sysctl: add sysctl macro test
Date: Mon, 25 Apr 2022 12:58:28 -0700 [thread overview]
Message-ID: <20220425125828.06cc0b51@kernel.org> (raw)
In-Reply-To: <20220422070141.39397-4-xiangxia.m.yue@gmail.com>
On Fri, 22 Apr 2022 15:01:41 +0800 xiangxia.m.yue@gmail.com wrote:
> static int __init test_sysctl_init(void)
> {
> + test_data.match_int[0] = *(int *)SYSCTL_ZERO,
> + test_data.match_int[1] = *(int *)SYSCTL_ONE,
> + test_data.match_int[2] = *(int *)SYSCTL_TWO,
> + test_data.match_int[3] = *(int *)SYSCTL_THREE,
> + test_data.match_int[4] = *(int *)SYSCTL_FOUR,
> + test_data.match_int[5] = *(int *)SYSCTL_ONE_HUNDRED,
> + test_data.match_int[6] = *(int *)SYSCTL_TWO_HUNDRED,
> + test_data.match_int[7] = *(int *)SYSCTL_ONE_THOUSAND,
> + test_data.match_int[8] = *(int *)SYSCTL_THREE_THOUSAND,
> + test_data.match_int[9] = *(int *)SYSCTL_INT_MAX,
> + test_data.match_int[10] = *(int *)SYSCTL_MAXOLDUID,
> + test_data.match_int[11] = *(int *)SYSCTL_NEG_ONE,
> + local VALUES=(0 1 2 3 4 100 200 1000 3000 $INT_MAX 65535 -1)
How does this test work? Am I reading it right that it checks if this
bash array is in sync with the kernel code?
I'd be better if we were checking the values of the constants against
literals / defines.
next prev parent reply other threads:[~2022-04-25 19:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 7:01 [net-next v4 0/3] use standard sysctl macro xiangxia.m.yue
2022-04-22 7:01 ` [net-next v4 1/3] net: sysctl: use shared " xiangxia.m.yue
2022-04-22 7:01 ` [net-next v4 2/3] net: sysctl: introduce sysctl SYSCTL_THREE xiangxia.m.yue
2022-04-22 7:01 ` [net-next v4 3/3] selftests/sysctl: add sysctl macro test xiangxia.m.yue
2022-04-25 19:58 ` Jakub Kicinski [this message]
2022-05-01 3:31 ` Tonghao Zhang
2022-05-02 14:26 ` Jakub Kicinski
2022-04-22 14:44 ` [net-next v4 0/3] use standard sysctl macro Luis Chamberlain
2022-04-22 19:43 ` Jakub Kicinski
2022-04-25 19:47 ` Luis Chamberlain
2022-04-25 19:56 ` Jakub Kicinski
2022-04-25 20:53 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425125828.06cc0b51@kernel.org \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=hmukos@yandex-team.ru \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lmb@cloudflare.com \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=shuah@kernel.org \
--cc=xiangxia.m.yue@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).