From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F39C433FE for ; Mon, 25 Apr 2022 16:54:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242155AbiDYQ52 (ORCPT ); Mon, 25 Apr 2022 12:57:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235375AbiDYQ50 (ORCPT ); Mon, 25 Apr 2022 12:57:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F6E43A739; Mon, 25 Apr 2022 09:54:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 963F361338; Mon, 25 Apr 2022 16:54:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC2B5C385A7; Mon, 25 Apr 2022 16:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650905660; bh=KXJVeHvfBoeQRSEK/W6Wv+6jM5VvVPCcOez/eDrDa1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=re87esaQWebxX3nfjHmMciUuhhC1LDKwLCuG7M+0mkFIuf6LR+a/n4c9h1V+C54eG DadjpAAgQP5J12j9f6RO2lqNhPVYbMn0weoP90W8++PUVGZ7OwY0OBLneHX6aOGg0s V+6SMQxFOpDbiN/aDkuwcyVTU8uHG3zaGN3zm9PewFypc+FEnCh4ZjtvD8JOmM+ah/ ErgvD1qIdx4fC7mX4YZ4s24KS624NdBHSAxB/lkhjqKp4n88pnk/snSq0zUpBUyGDb /omD9QlzDiqrLuXTUPgm/x8FvybYfkwJKTJE47IGJozAqtdZ5YENtG2WglOfwPe4Xo J94od0WvEUWAA== Date: Mon, 25 Apr 2022 09:54:19 -0700 From: "Darrick J. Wong" To: Yang Xu Cc: linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, viro@zeniv.linux.org.uk, david@fromorbit.com, brauner@kernel.org, willy@infradead.org, jlayton@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v6 2/4] fs: Add missing umask strip in vfs_tmpfile Message-ID: <20220425165419.GE16996@magnolia> References: <1650856181-21350-1-git-send-email-xuyang2018.jy@fujitsu.com> <1650856181-21350-2-git-send-email-xuyang2018.jy@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1650856181-21350-2-git-send-email-xuyang2018.jy@fujitsu.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Apr 25, 2022 at 11:09:39AM +0800, Yang Xu wrote: > All creation paths except for O_TMPFILE handle umask in the vfs directly > if the filesystem doesn't support or enable POSIX ACLs. If the filesystem > does then umask handling is deferred until posix_acl_create(). > Because, O_TMPFILE misses umask handling in the vfs it will not honor > umask settings. Fix this by adding the missing umask handling. > > Fixes: 60545d0d4610 ("[O_TMPFILE] it's still short a few helpers, but infrastructure should be OK now...") If I had a nickel for every time I felt like I was short a few helpers... ;) Reviewed-by: Darrick J. Wong --D > Cc: # 4.19+ > Reported-by: Christian Brauner (Microsoft) > Acked-by: Christian Brauner (Microsoft) > Signed-off-by: Yang Xu > --- > fs/namei.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/namei.c b/fs/namei.c > index 509657fdf4f5..73646e28fae0 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -3521,6 +3521,8 @@ struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns, > child = d_alloc(dentry, &slash_name); > if (unlikely(!child)) > goto out_err; > + if (!IS_POSIXACL(dir)) > + mode &= ~current_umask(); > error = dir->i_op->tmpfile(mnt_userns, dir, child, mode); > if (error) > goto out_err; > -- > 2.27.0 >