linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: linux-fsdevel@vger.kernel.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	Christoph Hellwig <hch@lst.de>,
	"Darrick J . Wong" <djwong@kernel.org>
Subject: [RFC PATCH 10/10] remove write_through bool
Date: Tue,  3 May 2022 07:40:08 +0100	[thread overview]
Message-ID: <20220503064008.3682332-11-willy@infradead.org> (raw)
In-Reply-To: <20220503064008.3682332-1-willy@infradead.org>

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 fs/iomap/buffered-io.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 5050adbd4bc8..ec0189dc6747 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -534,7 +534,6 @@ EXPORT_SYMBOL_GPL(iomap_migrate_page);
 struct iomap_write_ctx {
 	struct iomap_ioend *ioend;
 	struct list_head iolist;
-	bool write_through;
 };
 
 static void
@@ -587,7 +586,7 @@ static bool iomap_can_add_to_ioend(struct iomap *iomap,
 }
 
 static struct iomap_ioend *iomap_alloc_ioend(struct inode *inode,
-		struct iomap *iomap, loff_t offset, sector_t sector,
+		const struct iomap *iomap, loff_t offset, sector_t sector,
 		struct writeback_control *wbc)
 {
 	struct iomap_ioend *ioend;
@@ -888,7 +887,7 @@ static bool iomap_write_through(struct iomap_write_ctx *iwc,
 {
 	unsigned int blksize = i_blocksize(inode);
 
-	if (!iwc || !iwc->write_through)
+	if (!iwc)
 		return false;
 	if (folio_test_dirty(folio))
 		return true;
@@ -1078,13 +1077,13 @@ iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *i,
 	};
 	struct iomap_write_ctx iwc = {
 		.iolist = LIST_HEAD_INIT(iwc.iolist),
-		.write_through = iocb->ki_flags & IOCB_SYNC,
 	};
+	struct iomap_write_ctx *iwcp = iocb->ki_flags & IOCB_SYNC ? &iwc : NULL;
 	struct iomap_ioend *ioend, *next;
 	int ret;
 
 	while ((ret = iomap_iter(&iter, ops)) > 0)
-		iter.processed = iomap_write_iter(&iter, i, &iwc);
+		iter.processed = iomap_write_iter(&iter, i, iwcp);
 
 	list_for_each_entry_safe(ioend, next, &iwc.iolist, io_list) {
 		list_del_init(&ioend->io_list);
-- 
2.34.1


  parent reply	other threads:[~2022-05-03  6:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03  6:39 [RFC PATCH 00/10] Make O_SYNC writethrough Matthew Wilcox (Oracle)
2022-05-03  6:39 ` [RFC PATCH 01/10] iomap: Pass struct iomap to iomap_alloc_ioend() Matthew Wilcox (Oracle)
2022-05-03  6:40 ` [RFC PATCH 02/10] iomap: Remove iomap_writepage_ctx from iomap_can_add_to_ioend() Matthew Wilcox (Oracle)
2022-05-03  6:40 ` [RFC PATCH 03/10] iomap: Do not pass iomap_writepage_ctx to iomap_add_to_ioend() Matthew Wilcox (Oracle)
2022-05-03  6:40 ` [RFC PATCH 04/10] iomap: Accept a NULL iomap_writepage_ctx in iomap_submit_ioend() Matthew Wilcox (Oracle)
2022-05-03  6:40 ` [RFC PATCH 05/10] iomap: Allow a NULL writeback_control argument to iomap_alloc_ioend() Matthew Wilcox (Oracle)
2022-05-03  6:40 ` [RFC PATCH 06/10] iomap: Pass a length to iomap_add_to_ioend() Matthew Wilcox (Oracle)
2022-05-03  6:40 ` [RFC PATCH 07/10] iomap: Reorder functions Matthew Wilcox (Oracle)
2022-05-03  6:40 ` [RFC PATCH 08/10] " Matthew Wilcox (Oracle)
2022-05-03  6:40 ` [RFC PATCH 09/10] iomap: Add writethrough for O_SYNC Matthew Wilcox (Oracle)
2022-05-03  6:40 ` Matthew Wilcox (Oracle) [this message]
2022-05-03 12:57 ` [RFC PATCH 00/10] Make O_SYNC writethrough Damien Le Moal
2022-05-05  4:58 ` Dave Chinner
2022-05-05  5:07   ` Matthew Wilcox
2022-05-05  7:05     ` Dave Chinner
2022-05-06 12:03       ` Damien Le Moal
2022-05-10  1:26         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220503064008.3682332-11-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).