From: Chengguang Xu <cgxu519@mykernel.net>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, Chengguang Xu <cgxu519@mykernel.net>
Subject: [PATCH] vfs: move fdput() to right place in ksys_sync_file_range()
Date: Wed, 11 May 2022 11:45:03 -0400 [thread overview]
Message-ID: <20220511154503.28365-1-cgxu519@mykernel.net> (raw)
Move fdput() to right place in ksys_sync_file_range() to
avoid fdput() after failed fdget().
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/sync.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/sync.c b/fs/sync.c
index c7690016453e..b217d908bee8 100644
--- a/fs/sync.c
+++ b/fs/sync.c
@@ -360,10 +360,10 @@ int ksys_sync_file_range(int fd, loff_t offset, loff_t nbytes,
ret = -EBADF;
f = fdget(fd);
- if (f.file)
+ if (f.file) {
ret = sync_file_range(f.file, offset, nbytes, flags);
-
- fdput(f);
+ fdput(f);
+ }
return ret;
}
--
2.35.1
next reply other threads:[~2022-05-11 15:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 15:45 Chengguang Xu [this message]
2022-05-11 15:51 ` [PATCH] vfs: move fdput() to right place in ksys_sync_file_range() Matthew Wilcox
2022-05-11 19:01 ` Eric Biggers
2022-05-11 21:43 ` Al Viro
2022-05-12 0:28 ` Al Viro
2022-05-12 0:42 ` Jens Axboe
2022-05-12 2:03 ` Alexei Starovoitov
2022-05-12 12:48 ` Brian Vazquez
2022-05-15 3:30 ` [BUG] double fget() in vhost/net (was Re: [PATCH] vfs: move fdput() to right place in ksys_sync_file_range()) Al Viro
2022-05-15 16:14 ` Michael S. Tsirkin
2022-05-16 4:17 ` Jason Wang
2022-05-16 7:54 ` Michael S. Tsirkin
2022-05-16 8:42 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511154503.28365-1-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).