From: Luis Chamberlain <mcgrof@kernel.org>
To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Cc: patches@lists.linux.dev, amir73il@gmail.com, pankydev8@gmail.com,
tytso@mit.edu, josef@toxicpanda.com, jmeneghi@redhat.com,
jake@lwn.net, mcgrof@kernel.org
Subject: [PATCH 1/4] workflows/Kconfig: be consistent when enabling fstests or blktests
Date: Fri, 13 May 2022 12:38:28 -0700 [thread overview]
Message-ID: <20220513193831.4136212-2-mcgrof@kernel.org> (raw)
In-Reply-To: <20220513193831.4136212-1-mcgrof@kernel.org>
We have two kconfig variables which we use to be able to express
when we are going to enable fstests or blktests, either as a dedicated
set of tests or when we want to enable testing both fstests and blktests
in one system. But right now we only select this kconfig variable when
we are using a dedicated system. This is not an issue as the kconfig
is a kconfig symbols are bools which are set default to y if either
the test is dedicated or not.
But to be pedantic, and clear, let's make sure the tests select the
respective kconfig for each case as we'd expect to see it. Otherwise
this can confuse folks reading this.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
kconfigs/workflows/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kconfigs/workflows/Kconfig b/kconfigs/workflows/Kconfig
index 7e5c518..7f71470 100644
--- a/kconfigs/workflows/Kconfig
+++ b/kconfigs/workflows/Kconfig
@@ -133,6 +133,7 @@ if !WORKFLOWS_DEDICATED_WORKFLOW
config KDEVOPS_WORKFLOW_NOT_DEDICATED_ENABLE_FSTESTS
bool "fstests"
+ select KDEVOPS_WORKFLOW_ENABLE_FSTESTS
help
Select this option if you are doing filesystem development and want
to target development for a filesystem and enable fstests so that
@@ -146,6 +147,7 @@ config KDEVOPS_WORKFLOW_NOT_DEDICATED_ENABLE_FSTESTS
config KDEVOPS_WORKFLOW_NOT_DEDICATED_ENABLE_BLKTESTS
bool "blktests"
+ select KDEVOPS_WORKFLOW_ENABLE_BLKTESTS
help
Select this option if you are doing block layer development and want
to run blktests. The git tree for blktests will be git clone and
--
2.35.1
next prev parent reply other threads:[~2022-05-13 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 19:38 [PATCH 0/4] kdevops: use linux-kdevops for the main tree Luis Chamberlain
2022-05-13 19:38 ` Luis Chamberlain [this message]
2022-05-14 2:21 ` [PATCH 1/4] workflows/Kconfig: be consistent when enabling fstests or blktests Bart Van Assche
2022-05-15 15:10 ` Luis Chamberlain
2022-05-13 19:38 ` [PATCH 2/4] kdevops: move generic kdevops variables to its own file Luis Chamberlain
2022-05-13 19:38 ` [PATCH 3/4] playbooks: add a common playbook a git reset task for kdevops Luis Chamberlain
2022-05-20 14:44 ` Pankaj Raghav
2022-05-23 17:38 ` Luis Chamberlain
2022-05-13 19:38 ` [PATCH 4/4] kdevops: make linux-kdevops the default tree Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513193831.4136212-2-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=amir73il@gmail.com \
--cc=jake@lwn.net \
--cc=jmeneghi@redhat.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pankydev8@gmail.com \
--cc=patches@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).