From: Christoph Hellwig <hch@lst.de>
To: Khazhismel Kumykov <khazhy@google.com>
Cc: Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [RESEND][RFC PATCH] blkcg: rewind seq_file if no stats
Date: Tue, 17 May 2022 08:12:38 +0200 [thread overview]
Message-ID: <20220517061238.GB4789@lst.de> (raw)
In-Reply-To: <20220513174030.1307720-1-khazhy@google.com>
On Fri, May 13, 2022 at 10:40:30AM -0700, Khazhismel Kumykov wrote:
> Restores the previous behavior of only displaying devices for which we
> have statistics (and removes the current, broken, behavior of printing
> devname with no newline if no statistics)
>
> In lieu of get_seq_buf + seq_commit, provide a way to "undo" writes if
> we use seq_printf
I have to say I much prefer the simpler fix from Wolfgang. But
if we want to go down this route it needs to split into a patch
for the seq_file infrastruture and a separate one for the blk-cgroup
code.
next prev parent reply other threads:[~2022-05-17 6:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACGdZYLMW2KHVebfyJZVn9G=15N+Jt4+8oF5gq3wdDTOcXbk9A@mail.gmail.com>
2022-05-12 23:29 ` [RFC PATCH] blkcg: rewind seq_file if no stats Khazhismel Kumykov
2022-05-13 16:30 ` Tejun Heo
2022-05-13 17:40 ` [RESEND][RFC " Khazhismel Kumykov
2022-05-13 18:06 ` Khazhy Kumykov
2022-05-17 6:12 ` Christoph Hellwig [this message]
2022-05-17 6:27 ` Khazhy Kumykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517061238.GB4789@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=khazhy@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).