From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>, Keith Busch <kbusch@fb.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
axboe@kernel.dk, Kernel Team <Kernel-team@fb.com>,
hch@lst.de, bvanassche@acm.org, damien.lemoal@opensource.wdc.com,
pankydev8@gmail.com
Subject: Re: [PATCHv4 8/9] block: relax direct io memory alignment
Date: Tue, 31 May 2022 08:30:31 +0200 [thread overview]
Message-ID: <20220531063031.GF21098@lst.de> (raw)
In-Reply-To: <Yo/jzEDENPKpD8Al@kbusch-mbp.dhcp.thefacebook.com>
On Thu, May 26, 2022 at 02:32:12PM -0600, Keith Busch wrote:
> On Thu, May 26, 2022 at 12:55:50PM -0600, Keith Busch wrote:
> >
> > Let me see how difficult it would be catch it early in blkdev_dio_aligned().
>
> Something like this appears to work:
This looks reasonable to me. Nits below:
> + if (!iov_iter_aligned(iter, bdev_dma_alignment(bdev),
> + bdev_logical_block_size(bdev) - 1))
This probably wants a helper so that it can also be reused by e.g.
iomap.
next prev parent reply other threads:[~2022-05-31 6:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 1:06 [PATCHv4 0/9] direct io dma alignment Keith Busch
2022-05-26 1:06 ` [PATCHv4 1/9] block: fix infiniate loop for invalid zone append Keith Busch
2022-05-26 1:48 ` Damien Le Moal
2022-05-31 6:19 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 2/9] block/bio: remove duplicate append pages code Keith Busch
2022-05-26 1:06 ` [PATCHv4 3/9] block: export dma_alignment attribute Keith Busch
2022-05-26 7:30 ` Eric Biggers
2022-05-26 1:06 ` [PATCHv4 4/9] block: introduce bdev_dma_alignment helper Keith Busch
2022-05-26 1:06 ` [PATCHv4 5/9] block: add a helper function for dio alignment Keith Busch
2022-05-26 1:54 ` Damien Le Moal
2022-05-31 6:22 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 6/9] block/merge: count bytes instead of sectors Keith Busch
2022-05-26 1:57 ` Damien Le Moal
2022-05-31 6:25 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 7/9] block/bounce: " Keith Busch
2022-05-26 1:58 ` Damien Le Moal
2022-05-30 15:08 ` Pankaj Raghav
2022-05-31 6:26 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 8/9] block: relax direct io memory alignment Keith Busch
2022-05-26 2:03 ` Damien Le Moal
2022-05-26 7:29 ` Eric Biggers
2022-05-26 13:50 ` Keith Busch
2022-05-26 18:13 ` Eric Biggers
2022-05-26 18:55 ` Keith Busch
2022-05-26 20:32 ` Keith Busch
2022-05-31 6:30 ` Christoph Hellwig [this message]
2022-05-26 1:06 ` [PATCHv4 9/9] fs: add support for dma aligned direct-io Keith Busch
2022-05-26 2:01 ` Damien Le Moal
2022-05-31 6:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531063031.GF21098@lst.de \
--to=hch@lst.de \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=ebiggers@kernel.org \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pankydev8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).