From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB8AC433EF for ; Thu, 9 Jun 2022 00:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231710AbiFIAf1 (ORCPT ); Wed, 8 Jun 2022 20:35:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231579AbiFIAf0 (ORCPT ); Wed, 8 Jun 2022 20:35:26 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 969D434659 for ; Wed, 8 Jun 2022 17:35:23 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id D99C710E7124; Thu, 9 Jun 2022 10:35:19 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nz68r-004MWd-BI; Thu, 09 Jun 2022 10:35:17 +1000 Date: Thu, 9 Jun 2022 10:35:17 +1000 From: Dave Chinner To: Al Viro Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jens Axboe , Matthew Wilcox Subject: Re: [PATCH 06/10] keep iocb_flags() result cached in struct file Message-ID: <20220609003517.GW227878@dread.disaster.area> References: <20220607233143.1168114-1-viro@zeniv.linux.org.uk> <20220607233143.1168114-6-viro@zeniv.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607233143.1168114-6-viro@zeniv.linux.org.uk> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=deDjYVbe c=1 sm=1 tr=0 ts=62a1404a a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=JPEYwPQDsx4A:10 a=7-415B0cAAAA:8 a=DwE5ZJX0-RbGLLA_BjwA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jun 07, 2022 at 11:31:39PM +0000, Al Viro wrote: > * calculate at the time we set FMODE_OPENED (do_dentry_open() for normal > opens, alloc_file() for pipe()/socket()/etc.) > * update when handling F_SETFL > * keep in a new field - file->f_i_flags; since that thing is needed only Can you name this f_iocb_flags, because I keep reading it the "f_i_" shorthand as "file_inode_".... Cheers, Dave. -- Dave Chinner david@fromorbit.com