From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.com>,
Dave Kleikamp <shaggy@kernel.org>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
jfs-discussion@lists.sourceforge.net
Subject: Re: [PATCH 1/5] ext2: remove nobh support
Date: Thu, 9 Jun 2022 05:54:19 +0200 [thread overview]
Message-ID: <20220609035419.GA31288@lst.de> (raw)
In-Reply-To: <YqDQ31eEWR4fRopC@casper.infradead.org>
On Wed, Jun 08, 2022 at 05:39:59PM +0100, Matthew Wilcox wrote:
> On Wed, Jun 08, 2022 at 05:04:47PM +0200, Christoph Hellwig wrote:
> > @@ -551,7 +548,8 @@ static int parse_options(char *options, struct super_block *sb,
> > clear_opt (opts->s_mount_opt, OLDALLOC);
> > break;
> > case Opt_nobh:
> > - set_opt (opts->s_mount_opt, NOBH);
> > + ext2_msg(sb, KERN_INFO,
> > + "nobh option not supported");
> > break;
>
> This is the only part I wonder about. Should we just silently accept
> the nobh option instead of emitting a message?
That is how ext2 handles other ignores messages. Note that it still
accepts the option, it just prints a short line in dmesg.
> Also, is it time to start emitting a message for nfs' intr option? ;-)
Talk to the nfs folks..
next prev parent reply other threads:[~2022-06-09 3:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 15:04 remove the nobh helpers Christoph Hellwig
2022-06-08 15:04 ` [PATCH 1/5] ext2: remove nobh support Christoph Hellwig
2022-06-08 16:39 ` Matthew Wilcox
2022-06-09 3:54 ` Christoph Hellwig [this message]
2022-06-09 17:32 ` Jan Kara
2022-06-08 15:04 ` [PATCH 2/5] jfs: stop using the nobh helper Christoph Hellwig
2022-06-08 15:04 ` [PATCH 3/5] fs: remove the nobh helpers Christoph Hellwig
2022-06-09 17:33 ` Jan Kara
2022-06-08 15:04 ` [PATCH 4/5] fs: don't call ->writepage from __mpage_writepage Christoph Hellwig
2022-06-09 17:31 ` Jan Kara
2022-06-10 8:00 ` Christoph Hellwig
2022-06-08 15:04 ` [PATCH 5/5] fs: remove the NULL get_block case in mpage_writepages Christoph Hellwig
2022-06-09 17:25 ` Jan Kara
2022-06-10 8:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609035419.GA31288@lst.de \
--to=hch@lst.de \
--cc=jack@suse.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).