From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1261C433EF for ; Fri, 10 Jun 2022 08:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347119AbiFJIAv (ORCPT ); Fri, 10 Jun 2022 04:00:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347149AbiFJIAo (ORCPT ); Fri, 10 Jun 2022 04:00:44 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A59A321D3DB; Fri, 10 Jun 2022 01:00:38 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 133BA68AA6; Fri, 10 Jun 2022 10:00:33 +0200 (CEST) Date: Fri, 10 Jun 2022 10:00:32 +0200 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Matthew Wilcox , Jan Kara , Dave Kleikamp , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, jfs-discussion@lists.sourceforge.net Subject: Re: [PATCH 5/5] fs: remove the NULL get_block case in mpage_writepages Message-ID: <20220610080032.GA29310@lst.de> References: <20220608150451.1432388-1-hch@lst.de> <20220608150451.1432388-6-hch@lst.de> <20220609172530.q7bzttn5v2orirre@quack3.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609172530.q7bzttn5v2orirre@quack3.lan> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jun 09, 2022 at 07:25:30PM +0200, Jan Kara wrote: > On Wed 08-06-22 17:04:51, Christoph Hellwig wrote: > > No one calls mpage_writepages with a NULL get_block paramter, so remove > > support for that case. > > > > Signed-off-by: Christoph Hellwig > > What about ntfs_writepages()? That seems to call mpage_writepages() with > NULL get_block() in one case... Oops, yeah.