From: Christoph Hellwig <hch@lst.de>
To: dsterba@suse.cz,
syzbot <syzbot+d2dd123304b4ae59f1bd@syzkaller.appspotmail.com>,
akpm@linux-foundation.org, clm@fb.com, dsterba@suse.com,
hch@lst.de, josef@toxicpanda.com, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, syzkaller-bugs@googlegroups.com,
willy@infradead.org
Subject: Re: [syzbot] KASAN: use-after-free Read in copy_page_from_iter_atomic (2)
Date: Tue, 14 Jun 2022 09:17:57 +0200 [thread overview]
Message-ID: <20220614071757.GA1207@lst.de> (raw)
In-Reply-To: <20220613193912.GI20633@twin.jikos.cz>
On Mon, Jun 13, 2022 at 09:39:12PM +0200, David Sterba wrote:
> On Fri, Jun 10, 2022 at 12:10:19AM -0700, syzbot wrote:
> > syzbot has bisected this issue to:
> >
> > commit 4cd4aed63125ccd4efc35162627827491c2a7be7
> > Author: Christoph Hellwig <hch@lst.de>
> > Date: Fri May 27 08:43:20 2022 +0000
> >
> > btrfs: fold repair_io_failure into btrfs_repair_eb_io_failure
>
> Josef also reported a crash and found a bug in the patch, now added as
> fixup that'll be in for-next:
The patch looks correct to me. Two things to note here:
- I hadn't realized you had queued up the series. I've actually
started to merge some of my bio work with the bio split at
submission time work from Qu and after a few iterations I think
I would do the repair code a bit differently based on that.
Can you just drop the series for now?
- I find it interesting that syzbot hits btrfs metadata repair.
xfstests seems to have no coverage and I could not come up with
a good idea how to properly test it. Does anyone have a good
idea on how to intentially corrupt metadata in a deterministic
way?
next prev parent reply other threads:[~2022-06-14 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 13:11 [syzbot] KASAN: use-after-free Read in copy_page_from_iter_atomic (2) syzbot
2022-06-10 1:24 ` syzbot
2022-06-10 7:10 ` syzbot
2022-06-13 19:39 ` David Sterba
2022-06-14 7:17 ` Christoph Hellwig [this message]
2022-06-14 8:50 ` Qu Wenruo
2022-06-15 13:21 ` Christoph Hellwig
2022-06-15 21:27 ` Qu Wenruo
2022-06-16 6:35 ` Christoph Hellwig
2022-06-16 14:57 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614071757.GA1207@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+d2dd123304b4ae59f1bd@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).