From: Christoph Hellwig <hch@lst.de>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCHv2 2/4] fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read
Date: Tue, 21 Jun 2022 08:34:32 +0200 [thread overview]
Message-ID: <20220621063432.GA826@lst.de> (raw)
In-Reply-To: <f53e945837f78c042bee5337352e2fa216d71a5a.1655715329.git.ritesh.list@gmail.com>
On Mon, Jun 20, 2022 at 02:34:35PM +0530, Ritesh Harjani wrote:
> submit_bh always returns 0. This patch drops the useless return value of
> submit_bh from ntfs_submit_bh_for_read(). Once all of submit_bh callers are
> cleaned up, we can make it's return type as void.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
and so sad that a newly merged file systems still does all this buffer head
crap :(
next prev parent reply other threads:[~2022-06-21 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 9:04 [PATCHv2 0/4] submit_bh: Drop unnecessary return values and API users Ritesh Harjani
2022-06-20 9:04 ` [PATCHv2 1/4] jbd2: Drop useless return value of submit_bh Ritesh Harjani
2022-06-20 9:04 ` [PATCHv2 2/4] fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read Ritesh Harjani
2022-06-20 9:10 ` Ritesh Harjani
2022-06-20 9:49 ` Jan Kara
2022-06-21 6:34 ` Christoph Hellwig [this message]
2022-06-20 9:04 ` [PATCHv2 3/4] fs/buffer: Drop useless return value of submit_bh Ritesh Harjani
2022-06-20 9:04 ` [PATCHv2 4/4] fs/buffer: Make submit_bh & submit_bh_wbc return type as void Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621063432.GA826@lst.de \
--to=hch@lst.de \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).