From: KP Singh <kpsingh@kernel.org>
To: bpf@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Cc: KP Singh <kpsingh@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Yosry Ahmed <yosryahmed@google.com>
Subject: [PATCH v5 bpf-next 4/5] bpf: Add a bpf_getxattr kfunc
Date: Tue, 28 Jun 2022 16:19:47 +0000 [thread overview]
Message-ID: <20220628161948.475097-5-kpsingh@kernel.org> (raw)
In-Reply-To: <20220628161948.475097-1-kpsingh@kernel.org>
LSMs like SELinux store security state in xattrs. bpf_getxattr enables
BPF LSM to implement similar functionality. In combination with
bpf_local_storage, xattrs can be used to develop more complex security
policies.
This kfunc wraps around __vfs_getxattr which can sleep and is,
therefore, limited to sleepable programs using the newly added
sleepable_set for kfuncs.
Signed-off-by: KP Singh <kpsingh@kernel.org>
---
kernel/trace/bpf_trace.c | 42 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index 4be976cf7d63..87496d57b099 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -20,6 +20,7 @@
#include <linux/fprobe.h>
#include <linux/bsearch.h>
#include <linux/sort.h>
+#include <linux/xattr.h>
#include <net/bpf_sk_storage.h>
@@ -1181,6 +1182,47 @@ static const struct bpf_func_proto bpf_get_func_arg_cnt_proto = {
.arg1_type = ARG_PTR_TO_CTX,
};
+__diag_push();
+__diag_ignore_all("-Wmissing-prototypes",
+ "kfuncs that are used in tracing/LSM BPF programs");
+
+ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode,
+ const char *name, void *value, int value__sz)
+{
+ return __vfs_getxattr(dentry, inode, name, value, value__sz);
+}
+
+__diag_pop();
+
+BTF_SET_START(bpf_trace_kfunc_ids)
+BTF_ID(func, bpf_getxattr)
+BTF_SET_END(bpf_trace_kfunc_ids)
+
+BTF_SET_START(bpf_trace_sleepable_kfunc_ids)
+BTF_ID(func, bpf_getxattr)
+BTF_SET_END(bpf_trace_sleepable_kfunc_ids)
+
+static const struct btf_kfunc_id_set bpf_trace_kfunc_set = {
+ .owner = THIS_MODULE,
+ .check_set = &bpf_trace_kfunc_ids,
+ .sleepable_set = &bpf_trace_sleepable_kfunc_ids,
+};
+
+static int __init bpf_trace_kfunc_init(void)
+{
+ int ret;
+
+ ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING,
+ &bpf_trace_kfunc_set);
+ if (!ret)
+ return ret;
+
+ return register_btf_kfunc_id_set(BPF_PROG_TYPE_LSM,
+ &bpf_trace_kfunc_set);
+
+}
+late_initcall(bpf_trace_kfunc_init);
+
static const struct bpf_func_proto *
bpf_tracing_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
{
--
2.37.0.rc0.161.g10f37bed90-goog
next prev parent reply other threads:[~2022-06-28 16:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 16:19 [PATCH v5 bpf-next 0/5] Add bpf_getxattr KP Singh
2022-06-28 16:19 ` [PATCH v5 bpf-next 1/5] btf: Add a new kfunc set which allows to mark a function to be sleepable KP Singh
2022-06-28 16:19 ` [PATCH v5 bpf-next 2/5] bpf: kfunc support for ARG_PTR_TO_CONST_STR KP Singh
2022-06-28 16:19 ` [PATCH v5 bpf-next 3/5] bpf: Allow kfuncs to be used in LSM programs KP Singh
2022-06-28 16:19 ` KP Singh [this message]
2022-06-28 17:22 ` [PATCH v5 bpf-next 4/5] bpf: Add a bpf_getxattr kfunc Christian Brauner
2022-06-28 17:23 ` Al Viro
2022-06-28 17:29 ` KP Singh
2022-06-28 16:19 ` [PATCH v5 bpf-next 5/5] bpf/selftests: Add a selftest for bpf_getxattr KP Singh
2022-06-28 17:33 ` Christian Brauner
2022-06-28 17:52 ` KP Singh
2022-06-28 22:28 ` Alexei Starovoitov
2022-06-29 8:11 ` Christian Brauner
2022-06-29 9:55 ` Christian Brauner
2022-06-30 3:02 ` Alexei Starovoitov
2022-06-30 11:45 ` Christian Brauner
2022-06-30 12:21 ` KP Singh
2022-06-30 12:23 ` KP Singh
2022-06-30 13:26 ` Christian Brauner
2022-06-30 13:29 ` KP Singh
2022-06-30 13:47 ` Christian Brauner
2022-06-30 14:37 ` Christian Brauner
2022-06-30 16:10 ` Casey Schaufler
2022-06-30 22:23 ` KP Singh
2022-06-30 23:23 ` Casey Schaufler
2022-07-01 8:32 ` Amir Goldstein
2022-07-01 8:58 ` Christian Brauner
2022-07-01 9:24 ` Amir Goldstein
2022-06-30 16:28 ` Amir Goldstein
2022-06-30 22:25 ` KP Singh
2022-06-28 17:13 ` [PATCH v5 bpf-next 0/5] Add bpf_getxattr Christian Brauner
2022-06-28 17:20 ` KP Singh
2022-06-28 17:21 ` KP Singh
2022-06-29 1:36 ` Dave Chinner
2022-06-29 2:00 ` KP Singh
2022-06-29 2:05 ` KP Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628161948.475097-5-kpsingh@kernel.org \
--to=kpsingh@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).