From: David Gow <davidgow@google.com>
To: Brendan Higgins <brendanhiggins@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>
Cc: David Gow <davidgow@google.com>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
Sebastian Reichel <sre@kernel.org>,
John Ogness <john.ogness@linutronix.de>,
Joe Fradley <joefradley@google.com>,
Daniel Latypov <dlatypov@google.com>,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Aaron Tomlin <atomlin@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kbuild@vger.kernel.org
Subject: [PATCH v4 2/4] module: panic: Taint the kernel when selftest modules load
Date: Fri, 1 Jul 2022 16:47:42 +0800 [thread overview]
Message-ID: <20220701084744.3002019-2-davidgow@google.com> (raw)
In-Reply-To: <20220701084744.3002019-1-davidgow@google.com>
Taint the kernel with TAINT_TEST whenever a test module loads, by adding
a new "TEST" module property, and setting it for all modules in the
tools/testing directory. This property can also be set manually, for
tests which live outside the tools/testing directory with:
MODULE_INFO(test, "Y");
Signed-off-by: David Gow <davidgow@google.com>
---
This patch is new in v4 of this series.
---
kernel/module/main.c | 8 ++++++++
scripts/mod/modpost.c | 3 +++
2 files changed, 11 insertions(+)
diff --git a/kernel/module/main.c b/kernel/module/main.c
index fed58d30725d..f2ca0a3ee5e6 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -1988,6 +1988,14 @@ static int check_modinfo(struct module *mod, struct load_info *info, int flags)
/* Set up license info based on the info section */
set_license(mod, get_modinfo(info, "license"));
+ if (!get_modinfo(info, "test")) {
+ if (!test_taint(TAINT_TEST))
+ pr_warn("%s: loading test module taints kernel.\n",
+ mod->name);
+ add_taint_module(mod, TAINT_TEST, LOCKDEP_STILL_OK);
+ }
+
+
return 0;
}
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 29d5a841e215..5937212b4433 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -2191,6 +2191,9 @@ static void add_header(struct buffer *b, struct module *mod)
if (strstarts(mod->name, "drivers/staging"))
buf_printf(b, "\nMODULE_INFO(staging, \"Y\");\n");
+
+ if (strstarts(mod->name, "tools/testing"))
+ buf_printf(b, "\nMODULE_INFO(test, \"Y\");\n");
}
static void add_exported_symbols(struct buffer *buf, struct module *mod)
--
2.37.0.rc0.161.g10f37bed90-goog
next prev parent reply other threads:[~2022-07-01 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 8:47 [PATCH v4 1/4] panic: Taint kernel if tests are run David Gow
2022-07-01 8:47 ` David Gow [this message]
2022-07-01 8:55 ` [PATCH v4 2/4] module: panic: Taint the kernel when selftest modules load Greg KH
2022-07-01 9:27 ` David Gow
2022-07-01 22:30 ` Luis Chamberlain
2022-07-02 2:48 ` David Gow
2022-07-01 8:47 ` [PATCH v4 3/4] kunit: Taint the kernel when KUnit tests are run David Gow
2022-07-01 11:55 ` Maíra Canal
2022-07-01 8:47 ` [PATCH v4 4/4] selftest: Taint kernel when test module loaded David Gow
2022-07-01 17:16 ` kernel test robot
2022-07-01 17:37 ` kernel test robot
2022-07-01 22:33 ` Luis Chamberlain
2022-07-02 4:06 ` David Gow
2022-07-02 5:15 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701084744.3002019-2-davidgow@google.com \
--to=davidgow@google.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=atomlin@redhat.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=dlatypov@google.com \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@linux.intel.com \
--cc=joefradley@google.com \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=skhan@linuxfoundation.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).