From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C8FCCCA47B for ; Tue, 5 Jul 2022 08:36:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230058AbiGEIgx (ORCPT ); Tue, 5 Jul 2022 04:36:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbiGEIgw (ORCPT ); Tue, 5 Jul 2022 04:36:52 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0D572AE7; Tue, 5 Jul 2022 01:36:51 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id CBA7068AA6; Tue, 5 Jul 2022 10:36:48 +0200 (CEST) Date: Tue, 5 Jul 2022 10:36:48 +0200 From: Christoph Hellwig To: Chaitanya Kulkarni Cc: linux-block@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, axboe@kernel.dk, agk@redhat.com, song@kernel.org, djwong@kernel.org, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, javier@javigon.com, johannes.thumshirn@wdc.com, bvanassche@acm.org, dongli.zhang@oracle.com, ming.lei@redhat.com, willy@infradead.org, jefflexu@linux.alibaba.com, josef@toxicpanda.com, clm@fb.com, dsterba@suse.com, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, jlayton@kernel.org, idryomov@gmail.com, danil.kipnis@cloud.ionos.com, ebiggers@google.com, jinpu.wang@cloud.ionos.com Subject: Re: [PATCH 5/6] nvmet: add verify emulation support for file-ns Message-ID: <20220705083648.GD19123@lst.de> References: <20220630091406.19624-1-kch@nvidia.com> <20220630091406.19624-6-kch@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630091406.19624-6-kch@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jun 30, 2022 at 02:14:05AM -0700, Chaitanya Kulkarni wrote: > For now, there is no way to map verify operation to the VFS layer API. > This patch emulates verify operation by offloading it to the workqueue > and reading the data using vfs layer APIs for both buffered io and > direct io mode. What does this buy us? I'm generally not too happy about adding actualy logic to nvmet, it is supposed to mostly just pass through operations support by block device or files.