From: Namjae Jeon <linkinjeon@kernel.org>
To: viro@zeniv.linux.org.uk
Cc: linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
smfrench@gmail.com, hyc.lee@gmail.com, senozhatsky@chromium.org,
Namjae Jeon <linkinjeon@kernel.org>
Subject: [PATCH v6 0/3] ksmbd patches included vfs changes
Date: Thu, 7 Jul 2022 21:32:02 +0900 [thread overview]
Message-ID: <20220707123205.6902-1-linkinjeon@kernel.org> (raw)
This patchset contains vfs changes that are needed to fix racy issue
in ksmbd. Added the 1/3 patch by Al's additional review comment.
Al Viro (1):
fs: introduce lock_rename_child() helper
Namjae Jeon (2):
ksmbd: remove internal.h include
ksmbd: fix racy issue from using ->d_parent and ->d_name
v6:
- rename __lookup_hash() to lookup_one_qstr_excl and export.
- change dget() to dget_parent() in unlink.
- lock parent of open file in smb2_open() to make file_present
worthable.
v5:
- add lock_rename_child() helper.
- remove d_is_symlink() check for new_path.dentry.
- use lock_rename_child() helper instead of lock_rename().
- use dget() instead of dget_parent().
- check that old_child is still hashed.
- directly check child->parent instead of using take_dentry_name_snapshot().
v4:
- switch the order of 3/4 and 4/4 patch.
- fix vfs_path_parent_lookup() parameter description mismatch.
v3:
- use dget_parent + take_dentry_name_snapshot() to check stability of source
rename in smb2_vfs_rename().
v2:
- add filename_lock to avoid racy issue from fp->filename. (Sergey Senozhatsky)
- fix warning: variable 'old_dentry' is used uninitialized (kernel
test robot)
Al Viro (1):
fs: introduce lock_rename_child() helper
Namjae Jeon (2):
ksmbd: remove internal.h include
ksmbd: fix racy issue from using ->d_parent and ->d_name
fs/internal.h | 2 -
fs/ksmbd/smb2pdu.c | 146 ++++-----------
fs/ksmbd/vfs.c | 415 +++++++++++++++++-------------------------
fs/ksmbd/vfs.h | 19 +-
fs/ksmbd/vfs_cache.c | 5 +-
fs/namei.c | 103 ++++++++---
include/linux/namei.h | 9 +
7 files changed, 299 insertions(+), 400 deletions(-)
--
2.34.1
next reply other threads:[~2022-07-07 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 12:32 Namjae Jeon [this message]
2022-07-07 12:32 ` [PATCH v6 1/3] ksmbd: remove internal.h include Namjae Jeon
2022-07-07 12:32 ` [PATCH v6 2/3] fs: introduce lock_rename_child() helper Namjae Jeon
2022-07-07 12:32 ` [PATCH v6 3/3] ksmbd: fix racy issue from using ->d_parent and ->d_name Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707123205.6902-1-linkinjeon@kernel.org \
--to=linkinjeon@kernel.org \
--cc=hyc.lee@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).