linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bob Peterson <rpeterso@redhat.com>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	Naohiro Aota <naohiro.aota@wdc.com>
Cc: Johannes Thumshirn <jth@kernel.org>,
	cluster-devel@redhat.com, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one
Date: Tue, 19 Jul 2022 06:13:08 +0200	[thread overview]
Message-ID: <20220719041311.709250-2-hch@lst.de> (raw)
In-Reply-To: <20220719041311.709250-1-hch@lst.de>

Use filemap_fdatawrite_wbc instead of generic_writepages in
gfs2_ail1_start_one so that the functin can also cope with address_space
operations that only implement ->writepages and to properly account
for cgroup writeback.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 fs/gfs2/log.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index f0ee3ff6f9a87..a66e3b1f6d178 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -131,7 +131,7 @@ __acquires(&sdp->sd_ail_lock)
 		if (!mapping)
 			continue;
 		spin_unlock(&sdp->sd_ail_lock);
-		ret = generic_writepages(mapping, wbc);
+		ret = filemap_fdatawrite_wbc(mapping, wbc);
 		if (need_resched()) {
 			blk_finish_plug(plug);
 			cond_resched();
@@ -222,8 +222,7 @@ void gfs2_ail1_flush(struct gfs2_sbd *sdp, struct writeback_control *wbc)
 	spin_unlock(&sdp->sd_ail_lock);
 	blk_finish_plug(&plug);
 	if (ret) {
-		gfs2_lm(sdp, "gfs2_ail1_start_one (generic_writepages) "
-			"returned: %d\n", ret);
+		gfs2_lm(sdp, "gfs2_ail1_start_one returned: %d\n", ret);
 		gfs2_withdraw(sdp);
 	}
 	trace_gfs2_ail_flush(sdp, wbc, 0);
-- 
2.30.2


  reply	other threads:[~2022-07-19  4:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19  4:13 remove iomap_writepage v2 Christoph Hellwig
2022-07-19  4:13 ` Christoph Hellwig [this message]
2023-01-18 21:22   ` [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one Andreas Gruenbacher
2023-01-19  6:22     ` Christoph Hellwig
2022-07-19  4:13 ` [PATCH 2/4] gfs2: remove ->writepage Christoph Hellwig
2022-07-19  4:13 ` [PATCH 3/4] zonefs: " Christoph Hellwig
2022-07-19  6:56   ` Chaitanya Kulkarni
2022-07-19  4:13 ` [PATCH 4/4] iomap: remove iomap_writepage Christoph Hellwig
2022-07-19  6:56   ` Chaitanya Kulkarni
2022-07-22 17:56   ` Darrick J. Wong
2022-07-28 11:10 ` remove iomap_writepage v2 Jan Kara
2022-07-28 14:18   ` Matthew Wilcox
2022-07-28 22:48     ` Dave Chinner
2022-07-28 23:26       ` Yang Shi
2022-07-29  9:22   ` Mel Gorman
2022-07-29 14:11     ` Christoph Hellwig
2022-08-01 15:31       ` Johannes Weiner
2022-08-10 20:43         ` Matthew Wilcox
2022-08-10 21:32           ` Andreas Grünbacher
2022-08-10 23:17             ` Matthew Wilcox
2022-08-11  5:58           ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2022-07-11  4:14 remove iomap_writepage Christoph Hellwig
2022-07-11  4:14 ` [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one Christoph Hellwig
2022-07-11 10:27   ` Andreas Gruenbacher
2022-07-11 14:30     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220719041311.709250-2-hch@lst.de \
    --to=hch@lst.de \
    --cc=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=djwong@kernel.org \
    --cc=jth@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    --cc=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).