From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Ira Weiny <ira.weiny@intel.com>, Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Bart Van Assche <bvanassche@acm.org>,
Kees Cook <keescook@chromium.org>,
Muchun Song <songmuchun@bytedance.com>,
Viacheslav Dubeyko <slava@dubeyko.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] hfsplus: Unmap the page in the "fail_page" label
Date: Tue, 9 Aug 2022 22:31:02 +0200 [thread overview]
Message-ID: <20220809203105.26183-2-fmdefrancesco@gmail.com> (raw)
In-Reply-To: <20220809203105.26183-1-fmdefrancesco@gmail.com>
Several paths within hfs_btree_open() jump to the "fail_page" label
where put_page() is called while the page is still mapped.
Call kunmap() to unmap the page soon before put_page().
Cc: Viacheslav Dubeyko <slava@dubeyko.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
fs/hfsplus/btree.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/hfsplus/btree.c b/fs/hfsplus/btree.c
index 66774f4cb4fd..3a917a9a4edd 100644
--- a/fs/hfsplus/btree.c
+++ b/fs/hfsplus/btree.c
@@ -245,6 +245,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id)
return tree;
fail_page:
+ kunmap(page);
put_page(page);
free_inode:
tree->inode->i_mapping->a_ops = &hfsplus_aops;
--
2.37.1
next prev parent reply other threads:[~2022-08-09 20:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 20:31 [PATCH 0/4] hfsplus: Replace kmap() with kmap_local_page() Fabio M. De Francesco
2022-08-09 20:31 ` Fabio M. De Francesco [this message]
2022-08-09 22:16 ` [PATCH 1/4] hfsplus: Unmap the page in the "fail_page" label Viacheslav Dubeyko
2022-08-09 20:31 ` [PATCH 2/4] hfsplus: Convert kmap() to kmap_local_page() in bnode.c Fabio M. De Francesco
2022-08-09 22:17 ` Viacheslav Dubeyko
2022-08-09 20:31 ` [PATCH 3/4] hfsplus: Convert kmap() to kmap_local_page() in bitmap.c Fabio M. De Francesco
2022-08-09 22:18 ` Viacheslav Dubeyko
2022-08-09 20:31 ` [PATCH 4/4] hfsplus: Convert kmap() to kmap_local_page() in btree.c Fabio M. De Francesco
2022-08-09 22:18 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809203105.26183-2-fmdefrancesco@gmail.com \
--to=fmdefrancesco@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=ira.weiny@intel.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).