linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <mszeredi@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	Amir Goldstein <amir73il@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Yu-li Lin <yulilin@google.com>,
	Chirantan Ekbote <chirantan@chromium.org>
Subject: [PATCH v3 6/9] vfs: make vfs_tmpfile() static
Date: Tue, 20 Sep 2022 21:36:29 +0200	[thread overview]
Message-ID: <20220920193632.2215598-7-mszeredi@redhat.com> (raw)
In-Reply-To: <20220920193632.2215598-1-mszeredi@redhat.com>

No callers outside of fs/namei.c anymore.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
 fs/namei.c         | 3 +--
 include/linux/fs.h | 3 ---
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index 5e4a0c59eef6..652d09ae66fb 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3583,7 +3583,7 @@ static int do_open(struct nameidata *nd,
  * On non-idmapped mounts or if permission checking is to be performed on the
  * raw inode simply passs init_user_ns.
  */
-struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
+static struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
 			   struct dentry *dentry, umode_t mode, int open_flag)
 {
 	struct dentry *child = NULL;
@@ -3622,7 +3622,6 @@ struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
 	dput(child);
 	return ERR_PTR(error);
 }
-EXPORT_SYMBOL(vfs_tmpfile);
 
 /**
  * tmpfile_open - open a tmpfile for kernel internal use
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 34e7a189565b..a445da4842e0 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2004,9 +2004,6 @@ static inline int vfs_whiteout(struct user_namespace *mnt_userns,
 			 WHITEOUT_DEV);
 }
 
-struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
-			   struct dentry *dentry, umode_t mode, int open_flag);
-
 struct file *tmpfile_open(struct user_namespace *mnt_userns,
 			  const struct path *parentpath,
 			  umode_t mode, int open_flag, const struct cred *cred);
-- 
2.37.3


  parent reply	other threads:[~2022-09-20 19:36 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 19:36 [PATCH v3 0/9] fuse tmpfile Miklos Szeredi
2022-09-20 19:36 ` [PATCH v3 1/9] cachefiles: tmpfile error handling cleanup Miklos Szeredi
2022-09-20 19:36 ` [PATCH v3 2/9] hugetlbfs: cleanup mknod and tmpfile Miklos Szeredi
2022-09-21  7:59   ` Christian Brauner
2022-09-20 19:36 ` [PATCH v3 3/9] vfs: add tmpfile_open() helper Miklos Szeredi
2022-09-21  8:09   ` Christian Brauner
2022-09-21 14:33     ` Miklos Szeredi
2022-09-20 19:36 ` [PATCH v3 4/9] cachefiles: use " Miklos Szeredi
2022-09-21  8:26   ` Christian Brauner
2022-09-21 14:44     ` Miklos Szeredi
2022-09-21 19:46     ` Al Viro
2022-09-22  8:04       ` Christian Brauner
2022-09-20 19:36 ` [PATCH v3 5/9] ovl: " Miklos Szeredi
2022-09-21  8:35   ` Christian Brauner
2022-09-20 19:36 ` Miklos Szeredi [this message]
2022-09-21  8:36   ` [PATCH v3 6/9] vfs: make vfs_tmpfile() static Christian Brauner
2022-09-20 19:36 ` [PATCH v3 7/9] vfs: move open right after ->tmpfile() Miklos Szeredi
2022-09-20 20:57   ` Al Viro
2022-09-21  3:06     ` Miklos Szeredi
2022-09-21  8:54       ` Christian Brauner
2022-09-21 14:53         ` Miklos Szeredi
2022-09-21 19:55       ` Al Viro
2022-09-21  9:03   ` Christian Brauner
2022-09-21 14:56     ` Miklos Szeredi
2022-09-21 15:09       ` Christian Brauner
2022-09-21 15:24         ` Miklos Szeredi
2022-09-20 19:36 ` [PATCH v3 8/9] vfs: open inside ->tmpfile() Miklos Szeredi
2022-09-21  9:08   ` Christian Brauner
2022-09-21 14:58     ` Miklos Szeredi
2022-09-21 15:07       ` Christian Brauner
2022-09-21 15:27         ` Miklos Szeredi
2022-09-21 15:36           ` Christian Brauner
2022-09-21 19:52         ` Al Viro
2022-09-20 19:36 ` [PATCH v3 9/9] fuse: implement ->tmpfile() Miklos Szeredi
2022-09-21  9:15   ` Christian Brauner
2022-09-21 15:00     ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220920193632.2215598-7-mszeredi@redhat.com \
    --to=mszeredi@redhat.com \
    --cc=amir73il@gmail.com \
    --cc=chirantan@chromium.org \
    --cc=dhowells@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=yulilin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).