From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5202C6FA90 for ; Fri, 23 Sep 2022 06:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230183AbiIWGn1 (ORCPT ); Fri, 23 Sep 2022 02:43:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbiIWGn0 (ORCPT ); Fri, 23 Sep 2022 02:43:26 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7B5B127CB2 for ; Thu, 22 Sep 2022 23:43:25 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id C5B6068AFE; Fri, 23 Sep 2022 08:43:22 +0200 (CEST) Date: Fri, 23 Sep 2022 08:43:22 +0200 From: Christoph Hellwig To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Seth Forshee , Christoph Hellwig , Al Viro Subject: Re: [PATCH 01/29] fs: pass dentry to set acl method Message-ID: <20220923064322.GA16489@lst.de> References: <20220922151728.1557914-1-brauner@kernel.org> <20220922151728.1557914-2-brauner@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922151728.1557914-2-brauner@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org This looks generally good to me. Can you split the non-tivial orangefs refactoring into a prep patch so that it stands out and can be properly documented? Also there's a bunch of externs that can be dropped in the lines you touch.