From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ABD4C433F5 for ; Sat, 8 Oct 2022 19:44:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229821AbiJHTo2 (ORCPT ); Sat, 8 Oct 2022 15:44:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbiJHTo0 (ORCPT ); Sat, 8 Oct 2022 15:44:26 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 352A22EF1C for ; Sat, 8 Oct 2022 12:44:26 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id n18-20020a17090ade9200b0020b0012097cso5918493pjv.0 for ; Sat, 08 Oct 2022 12:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mAgGQiYibt6/W5CAo+9L5oS3sdpJlLe5MrCeTey7nag=; b=J+8YFK6iUM86zYLhmFX3+t7qRzul/K4tXXW0089HqM4aCs4d/CCqPjf7/fv65zexgD XdhVVzx+W1tmmk8HUs48KiXHOjR0EtbRpYzJxa511QAN+oE4KpqYCS7blqqBQAVGwfYJ iQ5bB4mISKlyHvN15qjmcYHOxWgwHQyArJVN8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mAgGQiYibt6/W5CAo+9L5oS3sdpJlLe5MrCeTey7nag=; b=hsuI/jCzYEpQ2M11i5pR9kP1b5CaxiXNgVqYwmMjHav5Op7VSpbaisJegF0t6bItnB ENQGcHF5DtVZwvjnB3Z1j2nX748ibVoEpruD9LNPnv0ev9d0ENrCHmF9O5TiTZ/69Pha DpWZ36i/PfPLvflFW4Bjq8a3aUzusoRd7/fmenvAvqPnyonxEw1p1BgA8DQJDnUpgXhs RmhLyuWrpCUwzVg+eDRXkWBzcPkBZv4hHcBmQ5V1cedDEmirdlISvGtEbrpGsn37keHV ElwPTGRnpuIJMl3gfpQ6fpgyW2bjfJGwmzWCf6z+n0DQwQwJfaCQWTZWGfJlwaLCis/o JNew== X-Gm-Message-State: ACrzQf08Gq7Wo2XbQ6zMxN/nlJ+Av5Hf+6qSI1lemUDTYsRd85e2xpYH m7Y1tEpnUMbQ+mfRibXK1Opfcg== X-Google-Smtp-Source: AMsMyM5Z5KYwFCcKEpXGtIhO2+5Vjeb7DMKrGFgP2q/DnCM8F5oFUxdFuQDUtO23wSnmxSQlSSWygA== X-Received: by 2002:a17:902:e808:b0:17f:92cb:2fdd with SMTP id u8-20020a170902e80800b0017f92cb2fddmr7914995plg.137.1665258265543; Sat, 08 Oct 2022 12:44:25 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b1-20020a17090a100100b002005fcd2cb4sm6673353pja.2.2022.10.08.12.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Oct 2022 12:44:24 -0700 (PDT) Date: Sat, 8 Oct 2022 12:44:23 -0700 From: Kees Cook To: Ard Biesheuvel Cc: "Guilherme G. Piccoli" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, anton@enomsg.org, ccross@android.com, tony.luck@intel.com Subject: Re: [PATCH 5/8] pstore: Fix long-term implicit conversions in the compression routines Message-ID: <202210081242.0B0F8B7@keescook> References: <20221006224212.569555-1-gpiccoli@igalia.com> <20221006224212.569555-6-gpiccoli@igalia.com> <202210061634.758D083D5@keescook> <202210071234.D289C8C@keescook> <11e03e8d-7711-330d-e0d4-808ef9acec3a@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Oct 08, 2022 at 07:52:48PM +0200, Ard Biesheuvel wrote: > Again, please correct me if I am missing something here (Kees?). Are > there cases where we compress data that may be compressed already? Nope, for dmesg, it should all only be text. I'd agree -- the worst case seems a weird thing to need. -- Kees Cook