From: Kees Cook <keescook@chromium.org>
To: Paramjit Oberoi <pso@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
Dmitry Torokhov <dtor@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 1/1] pstore/ram: Ensure stable pmsg address with per-CPU ftrace buffers
Date: Tue, 11 Oct 2022 13:04:04 -0700 [thread overview]
Message-ID: <202210111302.3179DB77@keescook> (raw)
In-Reply-To: <CAHqLn7Hd6KaNYA=goS7=dumrG3wZedbV1+ANa+-dZzFPiP_vsQ@mail.gmail.com>
On Tue, Oct 11, 2022 at 12:59:50PM -0700, Paramjit Oberoi wrote:
> > Hm, interesting point. Since only ftrace is dynamically sized in this
> > fashion, how about just moving the pmsg allocation before ftrace, and
> > adding a comment that for now ftrace should be allocated last?
>
> That is a good idea, and it would solve the problem.
>
> The only downside is it would break some code that works today because it
> ran in contexts where the pmsg address was stable (no per-cpu ftrace
> buffers, or power-of-two CPUs).
I don't follow? And actually, I wonder about the original patch now --
nothing should care about the actual addresses. Everything should be
coming out of the pstore filesystem.
--
Kees Cook
next prev parent reply other threads:[~2022-10-11 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 18:36 [PATCH 0/1] pstore/ram: Ensure stable pmsg address with per-CPU ftrace buffers pso
2022-10-11 18:36 ` [PATCH 1/1] " pso
2022-10-11 19:38 ` Kees Cook
[not found] ` <CAHqLn7Hd6KaNYA=goS7=dumrG3wZedbV1+ANa+-dZzFPiP_vsQ@mail.gmail.com>
2022-10-11 20:04 ` Kees Cook [this message]
[not found] ` <CAHqLn7EG=iKmu1tMJ_Um4MmpLVztshfzACnrzcZqPvvcRRCKuQ@mail.gmail.com>
2022-10-11 22:22 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202210111302.3179DB77@keescook \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=dtor@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pso@chromium.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).