From: Florian Westphal <fw@strlen.de>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Andrew Morton <akpm@linux-foundation.org>,
Florian Westphal <fw@strlen.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
Thomas Graf <tgraf@suug.ch>,
kasan-dev@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-block@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-media@vger.kernel.org, linux-mips@vger.kernel.org,
linux-mm@kvack.org, linux-mmc@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
linux-parisc@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-s390@vger.kernel.org, linux-um@lists.infradead.org,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev,
netdev@vger.kernel.org, sparclinux@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible
Date: Thu, 13 Oct 2022 12:16:35 +0200 [thread overview]
Message-ID: <20221013101635.GB11818@breakpoint.cc> (raw)
In-Reply-To: <3026360.ZldQQBzMgz@eto.sf-tec.de>
Rolf Eike Beer <eike-kernel@sf-tec.de> wrote:
> Florian, can you comment and maybe fix it?
Can't comment, do not remember -- this was 5 years ago.
> Or you wanted to move the variable before the loop and keep the random state
> between the loops and only reseed when all '1' bits have been consumed.
Probably. No clue, best to NOT change it to not block Jasons series and
then just simplify this and remove all the useless shifts.
next prev parent reply other threads:[~2022-10-13 10:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 23:06 [PATCH v6 0/7] treewide cleanup of random integer usage Jason A. Donenfeld
2022-10-10 23:06 ` [PATCH v6 1/7] treewide: use prandom_u32_max() when possible, part 1 Jason A. Donenfeld
2022-10-11 9:58 ` Heiko Carstens
2022-10-10 23:06 ` [PATCH v6 2/7] treewide: use prandom_u32_max() when possible, part 2 Jason A. Donenfeld
2022-10-10 23:06 ` [PATCH v6 3/7] treewide: use get_random_{u8,u16}() when possible, part 1 Jason A. Donenfeld
2022-10-11 1:18 ` Elliott, Robert (Servers)
2022-10-11 3:00 ` Jason A. Donenfeld
2022-10-10 23:06 ` [PATCH v6 4/7] treewide: use get_random_{u8,u16}() when possible, part 2 Jason A. Donenfeld
2022-10-11 9:59 ` Heiko Carstens
2022-10-10 23:06 ` [PATCH v6 5/7] treewide: use get_random_u32() when possible Jason A. Donenfeld
2022-10-11 10:00 ` Heiko Carstens
2022-10-13 9:25 ` Rolf Eike Beer
2022-10-13 10:16 ` Florian Westphal [this message]
2022-10-13 11:40 ` Rolf Eike Beer
2022-10-13 16:21 ` Jason A. Donenfeld
2022-10-10 23:06 ` [PATCH v6 6/7] treewide: use get_random_bytes() " Jason A. Donenfeld
2022-10-10 23:06 ` [PATCH v6 7/7] prandom: remove unused functions Jason A. Donenfeld
2022-10-11 23:01 ` [PATCH v6 0/7] treewide cleanup of random integer usage Jakub Kicinski
2022-10-17 11:59 ` liulongfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013101635.GB11818@breakpoint.cc \
--to=fw@strlen.de \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=eike-kernel@sf-tec.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=kasan-dev@googlegroups.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).