* [PATCH] coredump: wrap dump_emit_page() in #ifdef CONFIG_ELF_CORE
@ 2022-10-23 21:46 Nam Cao
0 siblings, 0 replies; only message in thread
From: Nam Cao @ 2022-10-23 21:46 UTC (permalink / raw)
To: Alexander Viro; +Cc: namcaov, linux-fsdevel, linux-kernel
The function dump_emit_page() is only called in dump_user_range(), which
is wrapped in #ifdef CONFIG_ELF_CORE. This causes a build error when
CONFIG_ELF_CORE is disabled:
CC fs/coredump.o
fs/coredump.c:834:12: error: ‘dump_emit_page’ defined but not used [-Werror=unused-function]
834 | static int dump_emit_page(struct coredump_params *cprm, struct page *page)
| ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Wrap dump_emit_page() in #ifdef CONFIG_ELF_CORE to avoid build problem.
Signed-off-by: Nam Cao <namcaov@gmail.com>
---
fs/coredump.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/coredump.c b/fs/coredump.c
index 7bad7785e8e6..8663042ebe9c 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -831,6 +831,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
}
}
+#ifdef CONFIG_ELF_CORE
static int dump_emit_page(struct coredump_params *cprm, struct page *page)
{
struct bio_vec bvec = {
@@ -863,6 +864,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
return 1;
}
+#endif
int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
{
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-23 21:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-23 21:46 [PATCH] coredump: wrap dump_emit_page() in #ifdef CONFIG_ELF_CORE Nam Cao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).