From: Jeff Layton <jlayton@kernel.org>
To: chuck.lever@oracle.com
Cc: linux-nfs@vger.kernel.org, trond.myklebust@hammerspace.com,
linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/4] filelock: WARN when @filp and fl_file don't match
Date: Fri, 11 Nov 2022 16:55:34 -0500 [thread overview]
Message-ID: <20221111215538.356543-1-jlayton@kernel.org> (raw)
Eventually, I'd like to reduce the redundant arguments to the locking
APIs, but to get there we need to ensure the callers all set their file
locks sanely.
Adding the WARN_ON_ONCEs helped to find a couple of warts in lockd's
file handling. The first 3 patches fix those.
I'd like to see these included in v6.2, with an eye toward a locking API
cleanup in v6.3.
Thanks,
Jeff Layton (4):
lockd: set missing fl_flags field when retrieving args
lockd: ensure we use the correct file description when unlocking
lockd: fix file selection in nlmsvc_cancel_blocked
filelock: WARN_ON_ONCE when ->fl_file and filp don't match
fs/lockd/svc4proc.c | 1 +
fs/lockd/svclock.c | 17 ++++++++++-------
fs/lockd/svcproc.c | 1 +
fs/locks.c | 3 +++
4 files changed, 15 insertions(+), 7 deletions(-)
--
2.38.1
next reply other threads:[~2022-11-11 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 21:55 Jeff Layton [this message]
2022-11-11 21:55 ` [PATCH 1/4] lockd: set missing fl_flags field when retrieving args Jeff Layton
2022-11-11 21:55 ` [PATCH 2/4] lockd: ensure we use the correct file description when unlocking Jeff Layton
2022-11-11 21:55 ` [PATCH 3/4] lockd: fix file selection in nlmsvc_cancel_blocked Jeff Layton
2022-11-11 21:55 ` [PATCH 4/4] filelock: WARN_ON_ONCE when ->fl_file and filp don't match Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111215538.356543-1-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).