From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE007C4332F for ; Sat, 10 Dec 2022 15:58:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229775AbiLJP6R (ORCPT ); Sat, 10 Dec 2022 10:58:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229634AbiLJP6Q (ORCPT ); Sat, 10 Dec 2022 10:58:16 -0500 Received: from 1wt.eu (wtarreau.pck.nerim.net [62.212.114.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F2F6A12091; Sat, 10 Dec 2022 07:58:14 -0800 (PST) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 2BAFwBwK022555; Sat, 10 Dec 2022 16:58:11 +0100 Date: Sat, 10 Dec 2022 16:58:11 +0100 From: Willy Tarreau To: Jens Axboe Cc: Linus Torvalds , netdev , "linux-fsdevel@vger.kernel.org" Subject: Re: [GIT PULL] Add support for epoll min wait time Message-ID: <20221210155811.GA22540@1wt.eu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Jens, On Sat, Dec 10, 2022 at 08:36:11AM -0700, Jens Axboe wrote: > Hi Linus, > > I've had this done for months and posted a few times, but little > attention has been received. I personally think this is particularly cool, for having faced the same needs in the past. I'm just wondering how long we'll avoid the need for marking certain FDs as urgent (i.e. for inter-thread wakeup) which would bypass the min delay. I'm just seeing something a bit odd in this series: > ---------------------------------------------------------------- > epoll-min_ts-2022-12-08 > > ---------------------------------------------------------------- > Jens Axboe (8): > eventpoll: cleanup branches around sleeping for events > eventpoll: don't pass in 'timed_out' to ep_busy_loop() > eventpoll: split out wait handling > eventpoll: move expires to epoll_wq > eventpoll: move file checking earlier for epoll_ctl() > eventpoll: add support for min-wait > eventpoll: add method for configuring minimum wait on epoll context > eventpoll: ensure we pass back -EBADF for a bad file descriptor This last patch fixes a bug introduced by the 5th one. Why not squash it instead of purposely introducing a bug then its fix ? Or maybe it was just overlooked when you sent the PR ? Thanks, Willy