From: Christian Brauner <brauner@kernel.org>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] posix_acl: Use try_cmpxchg in get_acl
Date: Sun, 8 Jan 2023 12:42:28 +0100 [thread overview]
Message-ID: <20230108114228.3szmdq32lt25zbtp@wittgenstein> (raw)
In-Reply-To: <20221223104724.uurfko6bqzpjv5n5@wittgenstein>
On Fri, Dec 23, 2022 at 11:47:24AM +0100, Christian Brauner wrote:
> On Wed, Dec 21, 2022 at 08:35:40PM +0100, Uros Bizjak wrote:
> > Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old
> > in get_acl. x86 CMPXCHG instruction returns success in ZF flag,
> > so this change saves a compare after cmpxchg (and related move
> > instruction in front of cmpxchg).
> >
> > No functional change intended.
> >
> > Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> > Cc: Christian Brauner <brauner@kernel.org>
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > ---
>
> Looks ok to me. But it's not urgent so I'll circle back to this post
> -rc1.
Seems good to me. So if there are no objectsions, then applied, thanks!
[1/1] posix_acl: Use try_cmpxchg in get_acl
commit: 4e1da8fe031303599e78f88e0dad9f44272e4f99
next prev parent reply other threads:[~2023-01-08 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 19:35 [PATCH] posix_acl: Use try_cmpxchg in get_acl Uros Bizjak
2022-12-23 10:47 ` Christian Brauner
2023-01-08 11:42 ` Christian Brauner [this message]
[not found] <202207162205.iBwToBEr-lkp@intel.com>
2022-07-18 2:05 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-07-14 17:38 Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108114228.3szmdq32lt25zbtp@wittgenstein \
--to=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ubizjak@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).