From: David Sterba <dsterba@suse.cz>
To: Alexander Potapenko <glider@google.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
chao@kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>
Subject: Re: [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()
Date: Tue, 10 Jan 2023 13:47:45 +0100 [thread overview]
Message-ID: <20230110124745.GZ11562@suse.cz> (raw)
In-Reply-To: <CAG_fn=Waivo=jEEqp7uMjKXdAvqP3XPtnAQeiRfu6ptwPmkyjw@mail.gmail.com>
On Tue, Jan 10, 2023 at 01:27:03PM +0100, Alexander Potapenko wrote:
> On Tue, Nov 22, 2022 at 3:56 PM David Sterba <dsterba@suse.cz> wrote:
> >
> > On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote:
> > > When aops->write_begin() does not initialize fsdata, KMSAN may report
> > > an error passing the latter to aops->write_end().
> > >
> > > Fix this by unconditionally initializing fsdata.
> > >
> > > Suggested-by: Eric Biggers <ebiggers@kernel.org>
> > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > > Signed-off-by: Alexander Potapenko <glider@google.com>
> >
> > With the fixed Fixes: reference,
> >
> > Acked-by: David Sterba <dsterba@suse.com>
>
> Hi David,
>
> I've noticed that the ext4 counterpart of this patch is in the
> upstream tree already, whereas the affs, f2fs, hfs and hfsplus
> versions are not.
> Are they picked via a different tree?
I thought it would go in with the rest of the series but it seems that
the patches are meant to be merged independently, so I'll do the affs
part.
next prev parent reply other threads:[~2023-01-10 12:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 11:21 [PATCH 1/5] fs: ext4: initialize fsdata in pagecache_write() Alexander Potapenko
2022-11-21 11:21 ` [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate() Alexander Potapenko
2022-11-21 19:46 ` Eric Biggers
2022-11-22 8:57 ` Alexander Potapenko
2022-11-22 14:56 ` David Sterba
2023-01-10 12:27 ` Alexander Potapenko
2023-01-10 12:47 ` David Sterba [this message]
2023-01-10 18:42 ` Eric Biggers
2022-11-21 11:21 ` [PATCH 3/5] fs: f2fs: initialize fsdata in pagecache_write() Alexander Potapenko
2022-11-21 19:53 ` Eric Biggers
2023-01-23 6:59 ` Eric Biggers
2023-01-26 21:09 ` Jaegeuk Kim
2022-11-21 11:21 ` [PATCH 4/5] fs: hfs: initialize fsdata in hfs_file_truncate() Alexander Potapenko
2023-01-24 10:51 ` Alexander Potapenko
2023-01-24 21:04 ` Andrew Morton
2023-01-25 9:51 ` Alexander Potapenko
2022-11-21 11:21 ` [PATCH 5/5] fs: hfsplus: initialize fsdata in hfsplus_file_truncate() Alexander Potapenko
2022-11-21 19:48 ` [PATCH 1/5] fs: ext4: initialize fsdata in pagecache_write() Andrew Morton
2022-11-22 3:40 ` Matthew Wilcox
2022-11-21 19:52 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110124745.GZ11562@suse.cz \
--to=dsterba@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=glider@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).