From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09136C54EBC for ; Tue, 10 Jan 2023 12:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238528AbjAJMxj (ORCPT ); Tue, 10 Jan 2023 07:53:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238573AbjAJMxX (ORCPT ); Tue, 10 Jan 2023 07:53:23 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 729A81D1; Tue, 10 Jan 2023 04:53:21 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EB55D689A8; Tue, 10 Jan 2023 12:53:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1673355199; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/4JyicuY3evhKfwa7lCX5U+XOFdgvqjvFbsTGio2dso=; b=v7p1Rm4xJfuzoJC13b36PAT6vkY4FKSn+nx8wtgxLeeo/SpCbaazY59sTSifuo8YXthm0e gLvfxD2UJe+Pl29q1mi/iuyQOpbC7aDARhC6tAp6ykyFTDihx+PRR40Mhgk887OlkbcAvP xC54UtTr864IjkckxeMOEsX3P1w1BRk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1673355199; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/4JyicuY3evhKfwa7lCX5U+XOFdgvqjvFbsTGio2dso=; b=wXhwMAdYTsQPp3yooTONWtD6VlgYwSgigwjxEANiaDcczdFTQjqtIJviRiOiEw6H2Kah6M mI0qrI8JH9fXPcCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9AEFA1358A; Tue, 10 Jan 2023 12:53:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id so3XJL9fvWOBKQAAMHmgww (envelope-from ); Tue, 10 Jan 2023 12:53:19 +0000 Date: Tue, 10 Jan 2023 13:47:45 +0100 From: David Sterba To: Alexander Potapenko Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers Subject: Re: [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate() Message-ID: <20230110124745.GZ11562@suse.cz> Reply-To: dsterba@suse.cz References: <20221121112134.407362-1-glider@google.com> <20221121112134.407362-2-glider@google.com> <20221122145615.GE5824@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jan 10, 2023 at 01:27:03PM +0100, Alexander Potapenko wrote: > On Tue, Nov 22, 2022 at 3:56 PM David Sterba wrote: > > > > On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > > an error passing the latter to aops->write_end(). > > > > > > Fix this by unconditionally initializing fsdata. > > > > > > Suggested-by: Eric Biggers > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > > Signed-off-by: Alexander Potapenko > > > > With the fixed Fixes: reference, > > > > Acked-by: David Sterba > > Hi David, > > I've noticed that the ext4 counterpart of this patch is in the > upstream tree already, whereas the affs, f2fs, hfs and hfsplus > versions are not. > Are they picked via a different tree? I thought it would go in with the rest of the series but it seems that the patches are meant to be merged independently, so I'll do the affs part.