linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fs/pipe: Delete unused do_pipe_flags()
@ 2023-01-11  3:05 Chengming Zhou
  2023-01-11  3:14 ` Al Viro
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Chengming Zhou @ 2023-01-11  3:05 UTC (permalink / raw)
  To: viro; +Cc: linux-fsdevel, linux-kernel, Chengming Zhou

It looks like do_pipe_flags() is not used anywhere and not exported
too, so delete it. No any functional changes.

Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
 fs/pipe.c          | 11 -----------
 include/linux/fs.h |  1 -
 2 files changed, 12 deletions(-)

diff --git a/fs/pipe.c b/fs/pipe.c
index 42c7ff41c2db..9b6d7b6658f1 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -986,17 +986,6 @@ static int __do_pipe_flags(int *fd, struct file **files, int flags)
 	return error;
 }
 
-int do_pipe_flags(int *fd, int flags)
-{
-	struct file *files[2];
-	int error = __do_pipe_flags(fd, files, flags);
-	if (!error) {
-		fd_install(fd[0], files[0]);
-		fd_install(fd[1], files[1]);
-	}
-	return error;
-}
-
 /*
  * sys_pipe() is the normal C calling standard for creating
  * a pipe. It's not the way Unix traditionally does this, though.
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 452700c5fa1d..0b8fe4243f48 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3014,7 +3014,6 @@ static inline void i_readcount_inc(struct inode *inode)
 	return;
 }
 #endif
-extern int do_pipe_flags(int *, int);
 
 extern ssize_t kernel_read(struct file *, void *, size_t, loff_t *);
 ssize_t __kernel_read(struct file *file, void *buf, size_t count, loff_t *pos);
-- 
2.37.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-11 10:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-11  3:05 [PATCH] fs/pipe: Delete unused do_pipe_flags() Chengming Zhou
2023-01-11  3:14 ` Al Viro
2023-01-11  7:54 ` kernel test robot
2023-01-11 10:26 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).