From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6BDBC46467 for ; Wed, 11 Jan 2023 04:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231318AbjAKE3Z (ORCPT ); Tue, 10 Jan 2023 23:29:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235867AbjAKE2c (ORCPT ); Tue, 10 Jan 2023 23:28:32 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D45CBDFC6; Tue, 10 Jan 2023 20:26:46 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 13E4B68BEB; Wed, 11 Jan 2023 05:26:42 +0100 (CET) Date: Wed, 11 Jan 2023 05:26:41 +0100 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Matthew Wilcox , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Dave Kleikamp , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/7] minix: don't flush page immediately for DIRSYNC directories Message-ID: <20230111042641.GA15181@lst.de> References: <20230108165645.381077-1-hch@lst.de> <20230108165645.381077-4-hch@lst.de> <20230110082225.GB11947@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jan 11, 2023 at 02:20:41AM +0000, Al Viro wrote: > More seriously, all those ..._set_link() need to return an error and their > callers (..._rename()) need to deal with failures. That's actually what I did yesterday: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/remove-write_one_page